Problem/Motivation

In #3227033: Remove Quick Edit from core the quickedit module is going to be removed from core in 10.x. help_topics Is an experimental module which contains topics related to quickedit module.

Steps to reproduce

Proposed resolution

Move the tracker topics about quickedit from the help_topics module.

Since there's already a Contrib version of the quickedit module, the moved help topics should be added to that module as well. I've created #3264949: Move Quick Edit help topics to contrib Quick Edit module to do just that.

The actual removal of the quickedit-related help topics from core will take place in #3227033: Remove Quick Edit from core where currently the remove-quickedit-from-core-in-D10 patch lives.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3264945

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Spokje opened merge request !1825

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Split core.quickedit help topic into two helptopics one for content and on for settings editing and moved the content one to the quickedit module.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Mostly looks great, thanks. I noticed a few minor nits. I’ll push the fixes when I’m at my desk.

dww’s picture

dww
we/he/they
commented
Parent issue: » #3227033: Remove Quick Edit from core
spokje’s picture

spokje
Primary language Dutch
commented

@dww Thanks, but pushing the fixes would mean you're not eligible for RTBC any more.

Then again, you _might_ have some connections to people who are willing to do a review afterwards and RTBC it :)

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Thanks @dww and all the people in the Slack thread.

Resolved all threads, back to NR.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks great replacement with settings tray! wording could be checked on commit

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Priority: Normal » Major

Since the is blocking #3227033: Remove Quick Edit from core which has priority Major, I think this issue should also have that priority.

  • catch committed d034252 on 10.0.x 
    Issue #3264945 by Spokje, dww: Move quickedit help topics to quickedit...

  • catch committed 5fa8127 on 9.4.x 
    Issue #3264945 by Spokje, dww: Move quickedit help topics to quickedit...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Spokje closed merge request !1825

dww’s picture

dww
we/he/they
commented

Thanks, folks! Drat, sorry I didn't do this sooner, but as I was more closely reviewing the exact text in here before committing it to contrib, I found some bugs. Opened #3265492: Fix inaccuracies in quickedit help topic (after the split from settings_tray) to track them.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.