Problem/Motivation

1. Vartheme provides printability-related classes in /scss/layout/print.layout.scss that has been replaced:
page-break-after -> break-after
page-break-before -> break-before
page-break-inside -> break-inside

2. The file is using invalid unit value to property width width:3;.

Proposed resolution

1. Replace the old css properties.
2. Remove the width line since I can't find a use for it.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release varbase-9.0.5, vartheme_bs4-9.0.11

Varbase update type:

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mhawwari created an issue. See original summary.

mhawwari’s picture

Assigned: mhawwari » Unassigned
Status: Active » Needs review

  • mhawwari committed fc0779d on 9.0.x
    Issue #3262009: Fix print layout styling issues
    
Rajab Natshah’s picture

Assigned: Unassigned » Mohammed J. Razem
Issue summary: View changes
Issue tags: +varbase-9.0.5, +vartheme_bs4-9.0.11
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Status: Fixed » Closed (fixed)