Report width a little large

Hi NancyDru

I thought it might be a 'By Design' but worth asking in case it was a bug.

The only solution I could think of is to make the content area scrollable, assuming that were possible

regards
John

After thinking on the problem.. OK Sleeping I thought that why try and scroll the content area,, the information is in tables so why not scroll them instead?

You probably already know this , but just in case...

Some time back I needed to scroll a table and found a way of doing it with a bit of css. I know it works in IE7 and supposedly works fine in firefox and opera

Basically
Apply the CSS to a div around the table

.scroll{
                height: 600px;
	width: 600px;
	overflow:auto;
	margin:0; padding:5px; border:0;
	scrollbar-face-color: #6095C1;
	scrollbar-highlight-color: #C2D7E7;
	scrollbar-3dlight-color: #85AECF;
	scrollbar-darkshadow-color: #427AA8;
	scrollbar-shadow-color: #315B7D;
	scrollbar-arrow-color: #FFFFFF;
	scrollbar-track-color: #4DECF8S;
	text-align:justify;
}

I found the basic code elsewhere on the web.

As i dont have enough knowledge, I couldnt figure exactly how to apply it to the module (tried a few different ways without luck), but it definitely works for a table

The main issue is that the width is a fixed size.

Not sure if this would be an effective solution if it can be made to work with the module

I look forward to giving it a try

There appears to be a small issue in that the code is being applied to every level causing multiple scrollbars

for example

Modules uses the following code for itself and the module groups which then gives a scrollbar for Modules and the table of each group. The scrollbar really only needs applying at table level, which i am guessing is not as easy

  // Get modules from the System module functions.
  if ($sitedoc_settings['module_section']) {
    $output .= '<div class="sitedoc_section sitedoc_modules">';
    $fieldset = array(
      '#title' => t('Modules'),
      '#collapsible' => TRUE,
      '#collapsed' => FALSE,
      '#value' => sitedoc_get_modules($sitedoc_settings['module_suppress'], $sitedoc_settings['module_sort_order']),
      );  
    $output .=  theme('fieldset', $fieldset);
    

I will have a better look in the morning and give further details

This may take a few posts as i will be looking at different bits

I have found what appears to be an extra. its also in the official release. It adds teh word Blocks at teh top of the table in the Blocks section so is effectively redundant and inconsistent with other sections

line 1886

  $output = '<h3>'. t('Blocks') .'</h3>';

Made some progress

It appears that "sitedoc_section" is possibly in the wrong location

what I have done is to apply it around the #value of the $fieldset array

eg

  // Get vocabularies and their definitions.
  if ($sitedoc_settings['vocabulary_section']) {
    $output .= '<div class="sitedoc_vocabularies">';
    $fieldset = array(
      '#title' => t('Vocabularies'),
      '#collapsible' => TRUE,
      '#collapsed' => FALSE,
      '#value' => '<div class="sitedoc_section">'.sitedoc_get_vocabularies().'</div>',
      );  
    $output .=  theme('fieldset', $fieldset);

     // do we want to check for orphans in the Term_node table?
    if ($sitedoc_settings['orphan_term_node']) {
      $orphans = sitedoc_check_orphan_term_node($sitedoc_settings['delete_orphan_term_nodes']);
      $fieldset = array(
        '#title' => t('Orphan Term_nodes'),
        '#collapsible' => TRUE,
        '#collapsed' => ($orphans == '<p>'. t('No orphan term_nodes found.') .'</p>'),
        '#value' => '<div class="sitedoc_section">'.$orphans.'</div>',
      );  
    $output .=  theme('fieldset', $fieldset);
    }
    $output .= "</div>\n";
  }

At present there are a couple of places it doesnt appear to work

Modules where a module section has more than 1 module ie CCK you still get multiple scroll bars

and

Drupal where i seem to be getting an extra scroll bar which dissapears only when PHP Information is expanded (maybe a coding error ?)

( Note i am only using the default settings so some areas have not been checked)

I have also added a min-height of 60px to the CSS to cope with the Theme Enginse table which can look a little odd with all scrollbars and almost no visible content

Ok further update. the problems with Modules was down to me applying the code in the wrong location.

There is one perculiar issue remaining for Modules and that is for some reason the XML Sitemap entry is not affected. Maybe as its the bottom of the list ?

Other than this the only issue is to do with the extra scroll bar for the Drupal section

I have attached my version of the module so you can see where i have made the changes. Unfortunately i have not adjusted non displayed sections

and dont forget min-height: 100px; for the CSS

All testing has been on IE7 only

Found the cause of the XML Sitemap not working, i missed that the last entry was processed by different code

  // Flush the last set.
  if (count($rows) > 0) {
    $fieldset = array(
      '#title' => $previous,
      '#collapsible' => TRUE,
      '#collapsed' => TRUE,
      '#value' => theme('table', $header, $rows),
      );
    $output .=  theme('fieldset', $fieldset);
  }

Needs to change to the following

  // Flush the last set.
  if (count($rows) > 0) {
    $fieldset = array(
      '#title' => $previous,
      '#collapsible' => TRUE,
      '#collapsed' => TRUE,
      '#value' => theme('table', $header, $rows),
      );
    $output .=  '<div class="sitedoc_section">'.theme('fieldset', $fieldset).'</div>';
  }

Forgot to set the status back to active

Just found a small issue on line 600 which i thought may fix the Drupal section, unfortunately it didnt

  // Insert a wrapper division and a link back to the settings page. 
  $output = '<div class="site-documentation">'. l(t('Change settings.'), 'admin/settings/sitedoc') .'<br/><br/>';

There appears to be a missing closing div

  // Insert a wrapper division and a link back to the settings page. 
  $output = '<div class="site-documentation">'. l(t('Change settings.'), 'admin/settings/sitedoc') .'<br/><br/>'.'</div>';

Well i thiink i have exhausted my abilities to resolve the extra scroll bar for "Drupal" Though i did notice that the view phpinfo link in PHP Information takes me to an empty page

I found the tag, missed it first time. It came up as an error in the sourcecode using WeBuilder - Found the cause was another tag :)

I have attached the latest version of the module i have. The problem with teh modules section is now fixed
I have also included teh CSS file with the min-height tweak

The only outstanding issue is this scroll bar on the Drupal section for which I attach 2 images.

One when PHP information is closed which shows the scroll bar and the other when PHP Information is open showing the scrollbar missing

--
edit

I am currently looking at something i saw the other day which provides Fixed Table Headers and allows the first column to be locked. It may be a nice way of adding navigation of the tables following the latest changes

http://home.tampabay.rr.com/bmerkey/examples/locked-column-csv.html

I think i have narrowed down the culprit for the scrollbar

  // Get basic Drupal info.

      '#value' => sitedoc_drupal($sitedoc_settings['kill_cron']),

I swapped for the similar line from Modules ( also multi part) and no extra scroll bar was present

further playing brings it down to "sitedoc_drupal" which I stripped as far as I can leaving just

/**
 *   Produce the basic system overview.
 */
function sitedoc_drupal($kill_cron=0) {

  $header = array(t('Item'), t('Value'), t('Operation'));
  $rows = array();

  $fieldset = array(
    '#title' => t('Drupal'),
    '#collapsible' => TRUE,
    '#collapsed' => FALSE,
    '#value' => '<div class="sitedoc_section">'.theme('table', $header, $rows).'</div>'."\n",
    );
    $output .=  theme('fieldset', $fieldset);

  return $output;
}

When you collape the last subsection, in this case Drupal, you get a scrollbar appear. when it is not collapsed there is no scrollbar.

I noticed that the effect was always for the last fieldset to be displayed it could be Drupal, Webserver Information, or PHP Information

edit : Why i hadnt noticed it before, but I just found that if you collapse "Database Information" you get a mini scroll bar

I can probably provide a list of changes with line numbers based on the current dev version if that helps, but have no idea how to create a patch :)

Ok, i am working without a net here :)

The attached patch probably doesn't conform to any standards but hopefully gives you all the info needed

NOTES:

Some fieldsets have not been modified (namely ones i havn't used - or better put - those default off), so will probably need similar tweaks

I have not included the one change I made for the CSS file for Sitedoc Section which is as fillows

min-height: 100px; 

BTW I played with the CSS from the link earlier which provides fixed headers, and it almost works - i will keep playing :)

So i didnt do too bad;) I used winmerge and tweaked teh output to what made sense to me. Having never seen teh package till yesterday i still have quite a lot to learn.

I did find a settingfor Unified which o assume relates to - u ( gives a more verbose output) but what would -p relate to ?

I will take a look at what you have for 6 later this evening

As my winmerge experience extends to but 1 day, its not to late to change, Is there a better visual, windows program you would recomend, that provides the features -u and -p , and anything else thats important to creating patches, to make life easier for you?

Searching Drupal gave me this page http://drupal.org/node/324 amongst many, but there were broken links and lots of choices :)

I have started to add the extra code to the other section

'URL aliases' has the same issue as the 'Drupal' section as in the extra scroll bar. I have also removed an extra header from 'Input Formats and Filters. basically repetition of the block title

looking at your own patch for 6 i noticed that for 'drupal_section. you moved the class to the value, but as far as i can tell there is no table in that section , so does it need to be applied? The same applies to 'table_section'

for roles section I applied the code around $rpt rather than the #value because you have an option for No Roles Found which IIRC when i tried it, it complicated the matter

My knowledge of coding is like a drop in the atlantic, so my approach could and most probably is wrong :)

i will keep working on v5 and submit an updated patch later today

Ok suffering a little confusuion here, and its probably down to my ignorance on how things work

If i go to

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/sitedoc/sit...

and view or download the latest revision 1.48.2.11 the id inside states 1.48.2.10

if i downlad the dev package

http://ftp.drupal.org/files/projects/sitedoc-5.x-1.x-dev.tar.gz

I get 1.48.2.11

Which should I work against ?

You probably know far more about CVS than I , blonde or not. Hey I only just realised I could get to it !

Attached you will find the latest version of my patch. There are still a couple of places where the extra scrollbar appears , but I suspect this is down to the nesting of sections, which is beyond my current ability, maybe next month;)

I made a small change also to the submit button code, changing the closing div code to suffix rather than prefix. I had noticed on a very wide screen 1600+ IE7 the submit button was appearing to the right of the form not at the bottom which is where I would have expected it ( if its wrong please change it back)

I have also added the code for Contact and Profile but have not tested it (I dont use them)

Hi NancyDru, I moved my main site to D6 a while back, and from what I can tell the issues that occcured in D5 version are no longer their, though it could be old age affecting my memory :)

Sorry forgot to say, I could see the scrollable areas and they worked well in 6 :) just hadn't gone deep enough, i was thinking more on the scrollbars that kept appearing when they shouldnt. I cant confirm that the 5.x version is funtional but the 6.x version definitely is