Problem/Motivation

Few constants and functions are deprecated for 10.0 so its time to get rid of it

Proposed resolution

remove the file and usage, make sure no usage left

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

No

Release notes snippet

CommentFileSizeAuthor
#7 interdiff.txt2.46 KBandypost
#5 interdiff.txt448 bytesandypost
#5 3260778-5.patch13.54 KBandypost
#2 3260778-2.patch13.47 KBandypost
#7 3213895-7.patch11.08 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
StatusFileSize
new 3260778-2.patch13.47 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
daffie’s picture

daffie commented
Status: Needs review » Needs work

Style guide violation.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Related issues: +#2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service
StatusFileSize
new 3260778-5.patch13.54 KB
new interdiff.txt448 bytes

Fixing CS and remaining REQUEST_TIME will use separate set of issues #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service

Status: Needs review » Needs work

The last submitted patch, 5: 3260778-5.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Related issues: +#3260806: Remove deprecated code from core/lib/Drupal/Core/Config, +#3097889: Remove deprecated theme functions
StatusFileSize
new interdiff.txt2.46 KB
new 3213895-7.patch11.08 KB

removed unrelated hunks, they have own issues

- #3097889: Remove deprecated theme functions
- #3260806: Remove deprecated code from core/lib/Drupal/Core/Config

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed cb55076 on 10.0.x 
    Issue #3260778 by andypost, daffie: Remove deprecated code from...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed cb55076 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.