Problem/Motivation

Hi all

I'm running into an issue when translating a webform: the Confirmation Url translation field seems to be limited to 128 characters, while the original isn't. So whenever I need to translate the url by -for example- adding an extra token field needed for the specific language, I'm getting validation errors stating that the field may not contain more characters than 128, which is a bit few, certainly when you are using a handful of submission tokens to be added to let's say the querystring of the confirmation url...

Can this field be set to a larger length?

Thanks in advance!

grtz
Christophe

Steps to reproduce

On a webform:
Enable the confirmation Url, and provide an url.
Translate the webform, and more specifically the confirmation url: try setting it to an url containing more than 128 characters for the specified language, and there you should run into the validation error...

Proposed resolution

Set the length of the translation field to match the length of the original (and larger) field (I'm assuming that would be 255 by default, or even longer, I don't know...), and no longer limit it to 128...

CommentFileSizeAuthor
#6 screenshot_confirmationurl.png66.36 KBmenwithbeards

Issue fork webform-3260223

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

menwithbeards created an issue. See original summary.

andregp’s picture

andregp commented
Category: Bug report » Feature request
andregp’s picture

andregp commented
Assigned: Unassigned » andregp

I'll see what I can do here...

andregp’s picture

andregp commented

@menwithbeards I couldn't find where to enable the confirmation Url. Could you share more details about the issue?

Which other modules you have installed?
Which Webforms sub-modules did you enable?
Could you share some screenshots?

Thanks,

jrockowitz’s picture

jrockowitz commented

I think a tweak needs to be made to \Drupal\webform\WebformTranslationConfigManager::alterConfigWebformForm

menwithbeards’s picture

menwithbeards commented
StatusFileSize
new screenshot_confirmationurl.png66.36 KB

@andregp thank you so much, here's a screenshot of where and how to setup the confirmation url...

no extra submodules have been enabled... the setup is fairly simple, just a webform, set to use a confirmation url, and a multilingual website (to allow the webform to be translated...)

@jrockowitz thank you for the tip, I already stumbled upon this file, but wasn't sure of what, where and how ;) thanks for narrowing it down to the exact location, I'm going to try something :)

... a wee bit later...

omg @jrockowitz, that so totally worked ;) ok, for the moment I have set the length to 255, is that ok? or should I be setting it to null ?(~unlimited)

I will try and create a patch for this, I suppose? (I haven't done that ever before, so forgive me if it's going to take a bit longer than you would normally expect a patch-writing thingie to take...)

menwithbeards opened merge request !133

menwithbeards opened merge request !134

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review

menwithbeards closed merge request !134

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Reviewed & tested by the community
andregp’s picture

andregp commented
Assigned: andregp » Unassigned
Status: Reviewed & tested by the community » Active

Sorry for the delay, yesterday was holiday for me. I see you already solved the issue.

andregp’s picture

andregp commented
Status: Active » Reviewed & tested by the community

Sorry, didn't mean to change the status

menwithbeards’s picture

menwithbeards commented

@andregp no problem! hope you enjoyed your free time! ;)

jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.