Problem/Motivation

In the parent issue dependencies were added. Most importantly: dealerdirect/phpcodesniffer-composer-installer. This means the readme is no longer correct. To load the Drupal sniffs you do not need to register the coding standards since they are loaded automaticly now.

phpcs --config-set installed_paths ~/.composer/vendor/drupal/coder/coder_sniffer

Steps to reproduce

n.a.

Proposed resolution

Update the readme and remote the part about requiring dealerdirect/phpcodesniffer-composer-installer and the manual registration.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3260071-4.patch1.06 KBvictoria-marina

Issue fork coder-3260071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bbrala created an issue. See original summary.

bbrala’s picture

bbrala
Location Netherlands
commented
victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina

I'll work on this.

victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned
Status: Active » Needs review
StatusFileSize
new 3260071-4.patch1.06 KB

Here is a patch.
Kindly review it.

bbrala’s picture

bbrala
Location Netherlands
commented

Thank you for taking the time to contribute :) Unfortunately the way to contribute is a little bit different for this module, from the module page:

Contributing

1. Make sure an issue exists in the issue queue
2. Create a Pull Request against https://github.com/pfrenssen/coder
3. Post a link to the pull request to the issue on drupal.org and set the issue to "needs review"

victoria-marina opened merge request !7

victoria-marina closed merge request !7

victoria-marina opened merge request !8

victoria-marina’s picture

victoria-marina commented

@bbrala done!

  • klausi committed adb06ef on 8.3.x 
    docs(README): Add local composer installation example and removed...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Update README » Cleanup README now that phpcs composer installer is a dependency
Version: 8.3.13 » 8.x-3.x-dev
Status: Needs review » Fixed

Thank you! I made an exception and committed your short patch. Please contribute changes on Github next time, that is our usual workflow.

I also cleaned up the README further and removed the composer installer part, not needed anymore.

bbrala’s picture

bbrala
Location Netherlands
commented

Thanks you @klausi :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

klausi closed merge request !8