Problem/Motivation

Currently we only support simple on/off for GestureHandling support, but missing support for its configuration options (see https://github.com/elmarquis/Leaflet.GestureHandling), e.g.

map.addControl(new L.Control.gestureHandling({
    duration: 1000,
    text: {
        touch: "Use two fingers to move the map",
        scroll: "Use ctrl + scroll to zoom the map",
        scrollMac: "Use \u2318 + scroll to zoom the map"
    },
}));

This PR reference our Marker Cluster configuration form design, refine GestureHandling configuration by provide a textarea for customize options.

Issue fork leaflet-3252846

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hswong3i created an issue. See original summary.

hswong3i’s picture

hswong3i commented
Status: Active » Needs review
Parent issue: » #2942651: Manage Leaflet library dependency with Composer & Asset Packagist

hswong3i opened merge request !9

hswong3i’s picture

hswong3i commented
Version: 2.1.x-dev » 3.0.x-dev

  • hswong3i committed b06d548 on 3.0.x 
    Issue #3252846 by hswong3i: Refine Gesture Handling Configure with...

  • itamair committed ab6bd39 on 3.0.x 
    Revert "Issue #3252846 by hswong3i: Refine Gesture Handling Configure...

itamair made their first commit to this issue’s fork.

itamair’s picture

itamair commented
Status: Needs review » Needs work

This cannot be approved as it is based on the 3.0.x-dev branch that is only experimental and not being supported now, in the short & mid term, because it doesn't provide a smooth and automatic upgrade path for all the 2.x users.

All this features requests should be also smoothly applicable to the 2.x branch, with full BW compatibility into it and upgrade/update path, to be approved ...

itamair closed merge request !9

itamair’s picture

itamair commented
Status: Needs work » Closed (outdated)