Add a menu link "Manage permissions" for bundles with associated permissions

thanks for the merge request! i've applied the diff to version 3.0.3 first and cleared caches. but unfortunately no menu link for manage permissions is showing in the admin menu. changed the admin_toolbar version to 3.0-dev afterwards and reapplied the patch plus cleared the caches on the drupal 9.3.0 alpha1 but same outcome. :( checked content types, media types, taxonomies and storage types (i have the storage module installed which provides custom entities). also checked admin/structure/menu/manage/admin and the manage permissions menu links also aren't showing there.

p.s. shall i test with version 3.0.3 or preferably 3.0-dev from now on for this issue?

that really really strange. i've used drush cr several times, cleared the cache globally in the developer menu in safari as well alt clicked the reload button. also tried with claro as well as seven as admin theme (always a drush cr afterwards). also restarted my local instance in ddev. really tried to iron out each and every possible detail i could think of. also tried another round of composer update drupal/admin_toolbar -w but no update found. and the submenu links still dont show up as you can see in the three linked images underneath:

the only thing left i could think of for the moment that some other module is interfering in some mysterious way. will uninstall all other non core modules stepwise and clear caches each time and see if the menu links are showing up like for you two. :/ if you have any other suggestions i might try i am all ears. oh and i also checked the source that the patch got applied. i can confirm it was.

hm i have only the initially created admin user i am logged in with on that install and the active roles for that user are "authenticated user", "content editor" and "Administrator". :/ maybe i try to install a fresh install of alpha1 and install directly admin_toolbar dev version and apply the patch and see if it works then.

created a completely new project (i use an ansible script for that to keep it reproducible and automated - could upload that in here as well). but same result unable to see the submenu link :( the last thing i might think of is the syntax for the patch in the composer.json. in the extra section i've added the following bit ( but i doubt that that is the reason.

"patchLevel": {
    "drupal/core": "-p2"
 },
 "patches": {
     "drupal/admin_toolbar": {
         "Add a menu link Manage permissions for bundles with associated permissions": "https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/15.diff"
     }
},

but aside that i am out of ideas (am not a programmer) :(

yep i already mentioned in #13 that i checked if the diff changes got actually applied to the codebase. rechecked now again and all changes in admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php got applied. :/ i'll add the file that you are able to compare and diff it with your working one (just had to rename the suffix from php to txt since php is not allowed)

I'be brought up the issue at the austin drupal dojo last night. @rocketeerbkw helped narrowing down what is causing the issue. he installed the patch on simplytest me and it worked like when you two tested it. then we commented out the following two lines on my failing installation

<code>$url = Url::fromRoute('entity.' . $bundle->getEntityTypeId() . '.permission_form', [$bundle->getEntityTypeId() => $machine_name]);
    if ($url->access($this->currentUser)) {

as well as the associated closing curly bracket. after that step the manage permissions tab showed up instantly as well as the menu links in the administration menu.
one observation and question about that detail. if you go to admin/people/permissions and take a look at the available field ui permissions you have permissions for administer display, administer fields, administer form display for content, custom blocks and taxonomy but none related to administer permissions there? while in the ExtraLinks.php all the snippets building the "manage..." tabs have no permission checks except the snippet you introduced in the merge request. so is the permission check necessary at all there? and on the other hand would the manage permissions tab need an administer permissions permission in the field ui section. perhaps we could ask @benji about that - the driving force behind the introduction of the manage permission tab.
i've then reverted the commented out lines back to the initial state of your patch and then we started comparing what is the difference between @rocketeerbkw simplytestme install and my failing one. at least we had an idea that it might be permission related. @rocketeerbkw also noted that when he installed simplytestme he just installed admin_toolbar and admin_toolbar_tools stepwise. when i setup a site testing i've automated everything with ansible and i drush en admin_toolbar and admin_toolbar_tools as well as admin_toolbar_links_access_filter at once. since i've been sensitised that it might be a permission related cause i've noticed that admin_toolbar_links_access_filter module description states

Provides a workaround for the common problem that users with 'Use the administration pages and help' permission see menu links they don't have access permission for

i've created a new test site manually and composer required admin_toolbar and installed its modules stepwise afterwards. first admin_toolbar and admin_toolbar_tools. there the manage permissions tab was showing up properly. but as soon as admin_toolbar_links_access_filter was installed the tab disappared. if you uninstall it again the tab as well as the menu links in that administration menu are showing up again. i don't know the exact why but at least i found the root causing it. hope that helps? :)

that is really strange. i've updated admin_toolbar on my new 9.3.0 beta1 installation to 3.x-dev and applied the diff. on that install i had only admin_toolbar and admin_toolbar_extra_tools installed. started to make screenshots to demonstrate with those two modules installed everything is working as expected. i then installed admin_toolbar_links_access_filter to demonstrate the effect i've described in #20. did a drush cr several times as well as cleared the browser caches once or twice. but somehow it is working now?!

i am able to see the manage permissions menu link for content types, media types, taxonomy types (Added and example screenshot for the article content type). but for comment types you showed the example for i am not able to. same for contact forms. not sure if contact forms are expected to have the manage permissions tab. same goes for the comment types. but there it should be supported since you've added a screenshot for them?

and i am testing the drupal 9.3.0beta1 with admin_toolbar 3.x-dev as admin user. and i havent tried anything non core.

it is really really strange. installed coffee ( composer require 'drupal/coffee:^1.2 ) after i've posted the comment. wanted to try if i am able to reach the manage permissions tabs as well. on drush en coffee i got:

[warning] Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies.
[warning] Entity view display 'node.forum.default': Component 'comment_forum' was disabled because its settings depend on removed dependencies.
[success] Successfully enabled: coffee

cleared caches. reloaded and then that (see screenshot coffee_article_content_type.png). if i uninstall coffee, clear caches the behavior is back to like described in #22 (see article_content_type.png in #22). really confusing :/

ahhh okay. was uncertain for a second. thanks for the clarification! then the patch works as expected. shall i set the status to rtbc? cuz there is still the behavior by the coffee module. not sure if that is an issue on the admin_toolbars end related to this issue here or if it is more of a coffee module issue. i've just mentioned it in here because i've noticed while testing and the effect is the exact same like i've experienced with this issue?

thats odd and confusing. i haven't changed anything at all to the time i've tested and wrote answer #27 but the sub menus links are showing up now again. that really confusing. and i am really unable to reproduce nor able to figure what was causing it. but i have the same four modules installed and everything is working. thanks a lot for the fix and your patience following along providing suggestion for possible causes. :) set it to rtbc now.