Problem/Motivation
Scaffold files were added to drupal/core in Drupal 8.8.x. During the Drupal 8
development cycle, the scaffold files are also being maintained in their original
locations. This is done so that Drupal sites based on the template project
drupal-composer/drupal-project may continue to download these files from the same
URLs they have historically been found at.The scaffold files will be deleted from their original location in Drupal 9.
See https://www.drupal.org/project/drupal/issues/3075954 for follow-on work.
1. It's not the Drupal 8 cycle any more.
2. We don't need to say when these were added any more; it's not relevant information.
3. #3075954: Remove duplicate scaffold files is still needs work, so I think saying the files will be removed in D9 is optimistic. Perhaps we should just say 'in a future version'?
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | interdiff_10-17.txt | 662 bytes | anagomes |
| #17 | 3247666-scaffold-files-17.patch | 1.12 KB | anagomes |
| #14 | Screen Shot 2022-01-05 at 2.18.35 PM.png | 232.56 KB | dandeleon03 |
| #10 | 3247666-scaffold-files.patch | 954 bytes | vicheldt |
| #4 | 3247666-scaffold-files.patch | 978 bytes | vicheldt |
Issue fork drupal-3247666
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
larowlanThis feels like a task to me
Comment #3
vicheldt commentedI'll change the documentation.
Comment #4
vicheldt commentedI removed all the text informing the reason when scaffold files were added on Drupal. If this patch looks ok let me know so I can create a MR, if it doesn't let me know what I can change.
Comment #6
longwaveThe test failure is unrelated, but one nit:
This text can be wrapped into a single paragraph.
Comment #7
joachim commentedIs this bit still true -- does that template still need this?
Comment #8
vicheldt commented@longwave if i put that all on a single paragraph, that'd be more than 80 characters on one line, isn't that against the coding standards?
Comment #9
vicheldt commented@joachim i am not sure that this part is needed because the scaffold files will be removed from the original location, so that part won't be true anymore, that's why i deleted that part of the documentation, but if that's still true let me know and i'll put it back.
Comment #10
vicheldt commentedI rephrased so that the text can be in one line that doesn't go over 80 characters.
Comment #11
vicheldt commentedComment #12
SomeIntern commentedPatch in #10 applied correctly to 9.3x, described changes to the documentation were made.
Comment #14
dandeleon03 commentedHi @vicheldt, @SomeIntern,
Patch in #10 is checked and verified and is correctly updated.
Please see screenshot.
Thanks.
Comment #15
joachim commentedWe've lost this part:
which is still relevant.
@dandeleon03 thanks for the review, but please don't post screenshots of diffs. There's no point, and it just uses up storage space.
Comment #16
anagomes commentedComment #17
anagomes commentedI added the part that @joachim mentioned in #15, I hope this is good enough.
Comment #18
dandeleon03 commentedHi @joachim
Apologies, since I am quite new to testing here. I'll bear it in mind next time.
@anagomes
Checked and confirmed that the one mentioned by @joachim in #15 is already added in your latest patch.
Thank you both.
Comment #19
alexpottCommitted and pushed f59f3ae9fba to 10.0.x and 71bd9d45fb0 to 9.4.x and 1a7b5c23e05 to 9.3.x. Thanks!
Backported to 9.3.x since this a docs fix.