Problem/Motivation

Method "Symfony\Component\DependencyInjection\ContainerBuilder::setDefinition()" will return "Definition" as of its next major version. Doing the same in child class "Drupal\Core\DependencyInjection\ContainerBuilder" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add "Definition" type hint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3231672-2.patch751 bytesdaffie

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie commented
Status: Active » Needs review
StatusFileSize
new 3231672-2.patch751 bytes

The fix.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Lots of references to ContainerBuilder in contrib, but they all look to be instantiating or type hinting, not subclassing.

http://grep.xnddx.ru/search?text=ContainerBuilder&filename=

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed da0ae6a and pushed to 9.3.x. Thanks!

  • larowlan committed da0ae6a on 9.3.x 
    Issue #3231672 by daffie: [Symfony 6] Add "Definition" type hint to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.