Problem/Motivation

When the minifyhtml source is enabled the permissions page is getting memory exhaust error. Do we need MinifyHTML in admin pages?

Steps to reproduce

Proposed resolution

Better to have a checkbox "Disable Minify for admin pages" in settings page where we can exclude the admin pages from minify.
OR
Disable minify for specific pages by providing a text field.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 minifyhtml-ignore-admin-pages-3230610-7.patch7.05 KBgeoanders
#6 minifyhtml-3230610.patch4.99 KBsriharsha.uppuluri
#4 minifyhtml-3230610.patch5.16 KBsriharsha.uppuluri

Issue fork minifyhtml-3230610

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sriharsha.uppuluri created an issue. See original summary.

sriharsha.uppuluri’s picture

sriharsha.uppuluri commented
Issue summary: View changes
sarjeet.singh’s picture

sarjeet.singh commented

I think, "Disable minify for specific pages" is good and we can disable all admin page with wild card (admin/*)

sriharsha.uppuluri’s picture

sriharsha.uppuluri commented
StatusFileSize
new minifyhtml-3230610.patch5.16 KB

Created the patch for the same.

sriharsha.uppuluri opened merge request !6

sriharsha.uppuluri’s picture

sriharsha.uppuluri commented
StatusFileSize
new minifyhtml-3230610.patch4.99 KB

Revised the patch for the 1.11 version.

sriharsha.uppuluri closed merge request !6

geoanders’s picture

geoanders commented
Version: 8.x-1.10 » 8.x-1.x-dev
StatusFileSize
new minifyhtml-ignore-admin-pages-3230610-7.patch7.05 KB

Tested out patch and seems to work as intended.

I added states to only show exclude_pages textarea field when "Minified Source HTML" is enabled.

* Probably need to update tests to factor in new setting.

slydevil’s picture

slydevil commented
Status: Active » Needs review

  • geoanders authored 6b882d3 on 8.x-1.x 
    Issue #3230610 by sriharsha.uppuluri, geoanders: Minify Settings Ignore...

  • 8b94369 committed on 8.x-1.x 
    Issue #3230610 added default excluded pages /admin*
slydevil’s picture

slydevil commented
Status: Needs review » Fixed
slydevil’s picture

slydevil commented
Status: Fixed » Closed (fixed)