Problem/Motivation

When going for a D9 upgrade on ContribKanban, it listed my custom profile as an uninstalled extension and something to be removed. But it is the default profile.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3230266.patch2.58 KBgábor hojtsy
#2 Screen Shot 2021-09-02 at 9.11.58 AM.png62.22 KBmglaman
Screen Shot 2021-08-27 at 3.35.00 PM.png43.91 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new Screen Shot 2021-09-02 at 9.11.58 AM.png62.22 KB

Here's another example of Commerce Base

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

We likely need to special case install profiles. I thought there was an issue about profiles being disabled in the module's queue, but I did not find it.

Apparently install profiles may be disabled and still function as the default profile. See #1170362: Install profile is disabled for lots of different reasons and core doesn't allow for that.

loopy1492’s picture

loopy1492 commented
Related issues: +#3047271: Add automated tests for handling install profiles
loopy1492’s picture

loopy1492 commented

Looks like this was done for 1.x branch at one point and never merged in.

https://git.drupalcode.org/project/upgrade_status/-/commit/a41d3939c2d86...

Edit: Actually, looking at the code for ProjectCollector.php in the 3.x branch, the code *is* in there. I wonder why the 1.x branch is able to find contrib modules in a profile, but the 3.x branch is not.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new 3230266.patch2.58 KB

@loopy1492: all the code under an install profile should be reported under the profile's name. This was originally by design as drupal.org install profiles would contain all self-hosted code. There were various reports of this assumption not being true in real life. See #3146667: Explore splitting the coverage of profiles into their subextensions for the issue to split them somehow.

For this issue though, the problem is the install profile is suggested to be removed, because it appear not installed. That is due to #1170362: Install profile is disabled for lots of different reasons and core doesn't allow for that as I wrote above. We can work around that though by adding a specific check for the install profile of the site. @mglaman could hopefully help validate this patch :D

firfin’s picture

firfin commented
Status: Needs review » Reviewed & tested by the community

Tested on 3.12 (not dev) applied cleanly there also. Sorry I didn't bother to test on a -dev version.

The install profile (i.e. commerce_base) moved from the 'Remove' section of the Upgrade Status report to the appropriate section.

Solved my problem. And code makes sense to me (which might be a sign that it is too 'simplistic' ;-) ).
So marking RTBC

  • e167342 committed on 8.x-3.x 
    Issue #3230266 by Gábor Hojtsy, mglaman, loopy1492, firfin: Custom...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Custom install profile is reported as an extension that should be uninstalled » Custom install profile is reported as an extension that should be uninstalled due to core bugs
Status: Reviewed & tested by the community » Fixed

Superb, thanks for testing, committed.

@loopy1492 et al. it would be great to see you in #3146667: Explore splitting the coverage of profiles into their subextensions, that is a more deep issue :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.