Problem/Motivation
While testing a patch from #3208259: Migrating from Media Entity to Media in core creates a new source field where one already existed I've discovered
that soundcloud shared music URL in SoundcloudEmbedFormatterTest is broken.
Check the https://soundcloud.com/winguy/billie-jean-remix-ft link.
This track was not found. Maybe it has been removed
Steps to reproduce
Just run test locally with an old url:
php core/scripts/run-tests.sh --verbose --module media_entity_soundcloud --sqlite /tmp/drupal/test.sqlite --url http://localhost
Proposed resolution
Replace music URL with (for example) https://soundcloud.com/grouchnz/michael-jackson-billie-jeangrouch-rmx.
I've tried to find a good alternative URL with lot's of likes and shares to assume that it is stable enought :)
Remaining tasks
- Create patch.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | media_entity_soundcloud-fix-non-working-test-link-3228191-5.patch | 773 bytes | vlad.dancer |
| #2 | media_entity_soundcloud-dummy-test-change-3228191-2.patch | 645 bytes | vlad.dancer |
Issue fork media_entity_soundcloud-3228191
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
vlad.dancerAdded the patch.
Comment #5
vlad.dancerOps, previously added a wrong patch.
Here is a good one.
Comment #6
vlad.dancerComment #7
rajeshreeputrathis is fixed with the latest release.
Comment #8
rajeshreeputraComment #9
rajeshreeputraComment #10
rajeshreeputraComment #11
rajeshreeputraComment #14
rajeshreeputradefault theme in test set to 'claro' as stable is removed from D10