Problem/Motivation

Right now, RollbackableTrait::import() marks every component as new if they were new before the actual import was executed.

This is wrong for e.g. field formatter settings, because the component might be new (missing) from the actual entity view display even after the migration; because its formatter in Drupal 7 was set to hidden.

Proposed resolution

Before marking a component as new, we should check whether it isn't new after the import. If it is still new, then the destination plugin shouldn't flag it as being new.

Remaining tasks

  1. ✅ Failing test-only patch.
  2. ✅ Fix.
  3. ✅ Commit to 1.1.x
  4. ✅ Cherry-pick to 1.0.x
  5. ✅ Update documentation.

API changes

No more harmful (and meaningless) exceptions.

CommentFileSizeAuthor
#17 interdiff-3227400-13-17.txt1.19 KBhuzooka
#17 migmag-fix_component_flagging-3227400-17--complete.patch9.98 KBhuzooka
#17 migmag-fix_component_flagging-3227400-17--test-only.patch5.93 KBhuzooka
#14 interdiff-3227400-13-14.txt1.19 KBhuzooka
#14 migmag-fix_component_flagging-3227400-14--complete.patch10.74 KBhuzooka
#14 migmag-fix_component_flagging-3227400-14--test-only.patch5.93 KBhuzooka
#13 interdiff-3227400-6-13.txt4.67 KBhuzooka
#13 migmag-fix_component_flagging-3227400-13--complete.patch10.74 KBhuzooka
#13 migmag-fix_component_flagging-3227400-13--test-only.patch5.93 KBhuzooka
#6 migmag-fix_component_flagging-3227400-6--complete.patch3.97 KBhuzooka
#6 migmag-fix_component_flagging-3227400-6--test-only.patch3.08 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

This should be get into 1.0.x as well.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Category: Task » Bug report
Priority: Critical » Major
Issue summary: View changes

Edit: #3227391: d7_field_formatter_settings should migrate the default view mode to default not full is only slightly related to this.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: -#3227391: d7_field_formatter_settings should migrate the default view mode to default not full
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Title: Suppress "Target already marked as being new" exceptions until 3227391 gets meaningful feedback » Check target component after the import before flagging as being new
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new migmag-fix_component_flagging-3227400-6--test-only.patch3.08 KB
new migmag-fix_component_flagging-3227400-6--complete.patch3.97 KB

The last submitted patch, 6: migmag-fix_component_flagging-3227400-6--test-only.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: migmag-fix_component_flagging-3227400-6--complete.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: +#3227549: Sql id map plugin's getRowByDestination shouldn't return FALSE

(Soft?)blocked by #3227549: Sql id map plugin's getRowByDestination shouldn't return FALSE.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: +#3227660: MigrateExecutable::rollback incorrectly assumes MigrateMapInterface::getRowByDestination() returns an array with 'rollback_action' key

...and an another one: #3227660: MigrateExecutable::rollback incorrectly assumes MigrateMapInterface::getRowByDestination() returns an array with 'rollback_action' key.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Hopefully #3227668: Add workarounds for core issues 3227549 and 3227660 can help MigMAg,but it will also mean that either:

  1. We have to depend on Smart SQL ID Map.
  2. We have use the SmartSql migrate ID map plugin if it is avaliable, but warn the users very loud that they should install it, or apply the corresponding core patches.
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: +#3227391: d7_field_formatter_settings should migrate the default view mode to default not full, +#3227668: Add workarounds for core issues 3227549 and 3227660
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new migmag-fix_component_flagging-3227400-13--test-only.patch5.93 KB
new migmag-fix_component_flagging-3227400-13--complete.patch10.74 KB
new interdiff-3227400-6-13.txt4.67 KB
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Needs work » Needs review
StatusFileSize
new migmag-fix_component_flagging-3227400-14--test-only.patch5.93 KB
new migmag-fix_component_flagging-3227400-14--complete.patch10.74 KB
new interdiff-3227400-13-14.txt1.19 KB

The last submitted patch, 14: migmag-fix_component_flagging-3227400-14--test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Patches in #13 and #14 are identical, unfortunately.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
StatusFileSize
new migmag-fix_component_flagging-3227400-17--test-only.patch5.93 KB
new migmag-fix_component_flagging-3227400-17--complete.patch9.98 KB
new interdiff-3227400-13-17.txt1.19 KB

The last submitted patch, 17: migmag-fix_component_flagging-3227400-17--test-only.patch, failed testing. View results

  • huzooka committed 9a3d09b on 1.1.x 
    Issue #3227400 by huzooka: Check target component after the import...
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Version: 1.1.x-dev » 1.0.x-dev
Issue summary: View changes

  • huzooka committed c015190 on 1.0.x 
    Issue #3227400 by huzooka: Check target component after the import...
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.