Problem/Motivation

Just discovered an additional bug in core's Sql ID map plugin: #3227549: Sql id map plugin's getRowByDestination shouldn't return FALSE.
...and an another one in MigrateExecutable, which might be worked around with an ID map plugin: #3227660: MigrateExecutable::rollback incorrectly assumes MigrateMapInterface::getRowByDestination() returns an array with 'rollback_action' key.

Proposed resolution

Add workarounds to Smart SQL ID map.

Remaining tasks

These are new things, so BEFORE doing anything:

  1. Open a new, 1.1.x branch
  2. Add a patch and test coverage
CommentFileSizeAuthor
#5 interdiff-3227668-3-5.txt1.31 KBhuzooka
#5 smart_sql_idmap-core_3227549_3227660_workarounds-3227668-5--complete.patch11.5 KBhuzooka
#5 smart_sql_idmap-core_3227549_3227660_workarounds-3227668-5--test-only.patch7.9 KBhuzooka
#3 smart_sql_idmap-core_3227549_3227660_workarounds-3227668-3--complete.patch11.09 KBhuzooka
#3 smart_sql_idmap-core_3227549_3227660_workarounds-3227668-3--test-only.patch7.48 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Both #3227549: Sql id map plugin's getRowByDestination shouldn't return FALSE and #3227660: MigrateExecutable::rollback incorrectly assumes MigrateMapInterface::getRowByDestination() returns an array with 'rollback_action' key have a fix and test coverage as well!

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new smart_sql_idmap-core_3227549_3227660_workarounds-3227668-3--test-only.patch7.48 KB
new smart_sql_idmap-core_3227549_3227660_workarounds-3227668-3--complete.patch11.09 KB

The last submitted patch, 3: smart_sql_idmap-core_3227549_3227660_workarounds-3227668-3--test-only.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new smart_sql_idmap-core_3227549_3227660_workarounds-3227668-5--test-only.patch7.9 KB
new smart_sql_idmap-core_3227549_3227660_workarounds-3227668-5--complete.patch11.5 KB
new interdiff-3227668-3-5.txt1.31 KB

The last submitted patch, 5: smart_sql_idmap-core_3227549_3227660_workarounds-3227668-5--test-only.patch, failed testing. View results

  • huzooka committed 6d32848 on 1.1.x 
    Issue #3227668 by huzooka: Add workarounds for core issues 3227549 and...
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs review » Fixed

Commited to 1.1.x. Right now I'm unable to change the target version somewhy.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Version: 1.0.x-dev » 1.1.x-dev
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.