Feature request to add a sub module that supports triggering Github Actions workflow dispatch event.
Based off of the Netlify sub module, this will support POST requests that require a Github personal access token.
See: https://docs.github.com/en/rest/reference/actions#create-a-workflow-disp...
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | github-actions-hooks-3227142-11.patch | 13.17 KB | petar_basic |
| #2 | github-actions-hooks-3227142-2.patch | 8.84 KB | ben.hamelin |
Comments
Comment #2
ben.hamelinPatch attached for new sub module.
Comment #3
larowlanThanks, this looks neat.
Can we get a test added and I'm happy to put this out as 3.3.0
See
\Drupal\Tests\build_hooks_bitbucket\Kernel\BitbucketBuildHooksTestfor an example, there are utility methods that make it pretty straightforward to add a new test.Comment #4
petar_basic commentedHere's a patch with implemented tests.
Comment #5
petar_basic commentedSorry, the patch in the previous comment was empty.
Comment #7
petar_basic commentedCorrected tests. Sorry for the multiple comments.
Comment #8
petar_basic commentedAnd here is the patch with corrected code styling/standards.
Comment #9
petar_basic commentedComment #10
larowlando we need this if we're not injecting any services?
happy to leave it in
Ah - we're implementing ContainerFactoryPluginInterface, but we're not using DI
Can we inject this?
And the messenger
this doesn't look implemented, so can be removed.
No need for the ajax callback (refreshDeploymentTable) and the comment about 'latest deployments' can go too
Tests look great, just some minor cleanup now.
Comment #11
petar_basic commentedUpdated the patch:
- Now injecting the config factory
- Removed the messenger since it was not used anywhere.
- Removed the ajax callback (refreshDeploymentTable) and the comment about 'latest deployments'
Comment #13
larowlanThanks, cutting 3.3.0