When Drupal is installing modules and syncing config it posts this notice

[info] entity_reference_revisions should have an extra.drush.services section in its composer.json. See http://docs.drush.org/en/10.x/commands/#specifying-the-services-file.

This patch adds the missing section.

CommentFileSizeAuthor
entity_reference_revisions_composer.patch457 bytesdrewble

Issue fork entity_reference_revisions-3225141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drewble created an issue. See original summary.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Active » Needs work 
+++ b/composer.json
@@ -2,6 +2,13 @@
+            "drush.services.yml": "^10"

Any reason to not allow Drush 9 as well? eg. "^9 || ^10"

timodwhit made their first commit to this issue’s fork.

timodwhit opened merge request !3

timodwhit’s picture

timodwhit commented
Status: Needs work » Needs review

Updated to Drush 9.

Berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

The MR only allows drush 9 now, it should allow both. That said, I think drush 9 is no longer maintained.

ndf made their first commit to this issue’s fork.

ndf’s picture

ndf commented
Status: Needs work » Needs review
ressa’s picture

ressa
he/him
commented

From the Drush 11 release note:

This release is recommended for all Drupal 9 sites. Drush 10 is no longer supported.

... so perhaps add Drush 11 support?

Also, Drush 9 reached EOL in May 2020, so should it be removed?

solideogloria’s picture

solideogloria commented
Version: 8.x-1.9 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Marking as RTBC, because it was tested on this issue and the patch worked and is basically the same.

#3225141: composer.json is missing extra.drush.services section

Drush 9 should not be removed. If the module is compatible, mark it as compatible. If the module removes its compatibility with Drush 9, then remove it.

If you use cweagans/composer-patches, the patch can be applied by adding this to composer.patches.json:

    "drupal/entity_reference_revisions": {
      "#3225141: composer.json is missing extra.drush.services section": "https://git.drupalcode.org/project/entity_reference_revisions/-/merge_requests/3.diff"
    },

  • Berdir committed a5bd17b on 8.x-1.x authored by timodwhit 
    Issue #3225141 by ndf, timodwhit, drewble, Berdir: composer.json is...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.