We have contrib modules that need to be updated to their latest versions. Lets do a full sweep before the 9.2 branch

CommentFileSizeAuthor
#10 sector-3223719-10-pre-9.2-healthcheck.patch2.44 KBxurizaemon
#8 sector-3223719-8-pre-9.2-healthcheck.patch2.29 KBxurizaemon
#2 sector-healthcheck_3223719_2.patch1.98 KBdanielveza

Issue fork sector-3223719

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DanielVeza created an issue. See original summary.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
StatusFileSize
new sector-healthcheck_3223719_2.patch1.98 KB
danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Active » Needs review

This has passed our internal testing. Crediting @emma_selley for that.

I'll leave this up for someone else to review & commit, otherwise I'll do it on Tuesday.

DanielVeza credited emma_selley.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Needs review » Needs work

I don't see core update in the diff. Is this on purpose or missed? Should be at 9.1.11. Looks like search_api is missing as well.

dieuwe’s picture

dieuwe
Location Auckland, NZ
commented

Both of those releases are more recent than the patch from #2, so yes they should be included before this is committed if possible (or followed up on in a second patch).

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes
StatusFileSize
new sector-3223719-8-pre-9.2-healthcheck.patch2.29 KB

Glad to see VBO 3.13 in there, our testing has shown up #3194846: The label output for checkboxes can relate to the wrong row which that hopefully will fix.

Attaching patch that includes the existing updates, core to 9.1.11 and CTools to 3.7 (ignore, bad patch).

Opening a related discussion about relaxing composer constraints in #3225472: Prefer caret rather than exact version constraints in composer.json to avoid hijacking this one :)

PS. Pls excuse me creating a fork for this patch also ... using it to try and work out how to get composer-patches to patch profile composer.json in a way that works.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Related issues: +#3219200: Security update - ctools
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new sector-3223719-10-pre-9.2-healthcheck.patch2.44 KB

Better patch :)

- drupal/core-recommended:9.1.9
+ drupal/core-recommended:9.1.11

- drupal/search_api:1.20
+ drupal/search_api:1.20

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs work » Needs review

xurizaemon opened merge request !11

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Needs review » Reviewed & tested by the community

This issue should be merged together with https://github.com/sparksi/sector-project/pull/12 . wysiwyg_template:3.0.0-rc2 requires ckeditor/templates:4.11.1 see https://www.drupal.org/project/wysiwyg_template

Otherwise RTBC

  • dieuwe committed 38dfb1f on 9.1.x authored by xurizaemon 
    Issue #3223719 by xurizaemon, DanielVeza, RoSk0, dieuwe, emma_selley: [...
dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
Status: Reviewed & tested by the community » Fixed

I should tag a new release shortly.

I've responded to the proposed sector-project template change as we already do ship ckeditor/templates out-of-the-box.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Chroid closed merge request !11