Per https://www.drupal.org/node/3201242, access checking should be explicit.

CommentFileSizeAuthor
#4 3223047-4-simple_sitemap-explicitly-check-query-access.patch360 bytesgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Reviewed & tested by the community » Active

Whoops.

gabesullice’s picture

gabesullice
Primary language English
commented
Parent issue: #3210294: Access checking must be explicitly specified on entity queries »

Whoops x2

gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new 3223047-4-simple_sitemap-explicitly-check-query-access.patch360 bytes

I'm not sure if this addresses all instances. It probably doesn't, but it addresses what's showing up in my CI environment and gets the ball rolling ;)

I'm also unsure if this should actually be written as ->accessCheck(FALSE). I went with TRUE because that preserves the working behavior. However, when I searched for usages of EntityHelper::getEntityInstanceIds(), it seems that access checking might actually be undesirable.

  • gbyte committed 636e30a on 8.x-3.x 
    Issue #3223047 by gbyte, gabesullice: Access checking must be explicitly...
gbyte’s picture

gbyte
Location Berlin
commented
Issue summary: View changes
Status: Active » Fixed

There was one other case. That's commited now, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.