Problem/Motivation

As a webform administrator, I would like to bulk close, archive, and delete multiple webforms.

Proposed resolution

Add bulk operations to the webform and webform submission manage pages

Add the below webform bulk operations:

  • Archive
  • Delete
  • Set category
  • Set status (open/close)

Webform submissions already have bulk operations. We would need to copy some code from \Drupal\views\Plugin\views\field\BulkForm to create a dedicated webform submission bulk form.

Remaining tasks

  • Build POC
  • Determine if 'Delete operation' needs a confirmation page
  • Determine who should have access to bulk operations.
  • TBD

User interface changes

Bulk operations will be visible to administrators

API changes

  • WebformEntityListBuilder and WebformSubmissionEntityListBuilder render array is going to need to be adjusted.
  • Webform submission delete action needs some refactoring.

Data model changes

N/A

CommentFileSizeAuthor
#48 3220703-48.patch1.23 KBjrockowitz
#47 3220703-47.patch1.23 KBjrockowitz
#43 3220703-43.patch69.16 KBjrockowitz
#40 3220703-41.patch69.16 KBjrockowitz
#34 3220703-34.patch66.55 KBjrockowitz
#26 3220703-25.patch46.87 KBjrockowitz
#22 3220703-23.patch42.06 KBjrockowitz
#21 3220703-22.patch0 bytesjrockowitz
#18 3220703-18.patch41.01 KBjrockowitz
#14 3220703-14.patch40.49 KBjrockowitz
#2 3220703-2.patch4.94 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3220703-2.patch4.94 KB

Attached is a very simple POC. What is nice about this approach is the bulk operations are being cleanly layered on top of the existing functionality.

jrockowitz’s picture

jrockowitz commented
Assigned: Unassigned » jrockowitz

  • 08c3c78 committed on 3220703-bulk-webform-operations 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...

  • fc19821 committed on 3220703-bulk-webform-operations 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...

  • 3754a50 committed on 3220703-bulk-webform-operations 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...
jrockowitz’s picture

jrockowitz commented

The attached patch adds bulk operation support for the webform manage UI.

This patch still needs some basic test coverage.

jrockowitz’s picture

jrockowitz commented
Issue summary: View changes

  • 8c13964 committed on 3220703-bulk-webform-operations 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...

  • e05a7fc committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • 9e585f7 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • 53f2b07 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • 1f7b066 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities
jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3220703-14.patch40.49 KB

Status: Needs review » Needs work

The last submitted patch, 14: 3220703-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • d72a6fa committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • c3ad9fc committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3220703-18.patch41.01 KB

Status: Needs review » Needs work

The last submitted patch, 18: 3220703-18.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • 4ad8109 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3220703-22.patch0 bytes
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3220703-23.patch42.06 KB

Status: Needs review » Needs work

The last submitted patch, 22: 3220703-23.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • 6a74850 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • ab0a957 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3220703-25.patch46.87 KB

  • 30f0246 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • 0fb149e committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • e76aeb7 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • b8b7522 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities
  • ce8e0b4 committed on 3220703-bulk-webform-operations
    Issue #3220703: Add support for bulk operations on webform entities

  • 955919e committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities

  • 2922b6f committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities....

  • 854c1e4 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities....
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3220703-34.patch66.55 KB

  • 00e76bb committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities....

  • ad4a420 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities....

  • 2f1763b committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities. Fix...

  • 55b06ba committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities.

  • aeb2924 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities.
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3220703-41.patch69.16 KB

Status: Needs review » Needs work

The last submitted patch, 40: 3220703-41.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • af0a5e7 committed on 3220703-bulk-webform-operations 
    Issue #3220703: Add support for bulk operations on webform entities.
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3220703-43.patch69.16 KB

  • jrockowitz authored 7c3653f on 8.x-5.x 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...

  • jrockowitz authored 7c3653f on 6.x 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3220703-47.patch1.23 KB

This patch is required to get bulk operations properly installed in 6.x

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3220703-48.patch1.23 KB

  • jrockowitz authored 35c4605 on 6.x 
    Issue #3220703 by jrockowitz: Add support for bulk operations on webform...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.