Remove testing of "base theme" info file key due to core fail

I got this error too, during `$ drush updatedb` on a Drupal 9.2 site.

I rolled a patch, in case anyone needs it. It works with versions 8.x-3.6 and 8.x-3.x-dev

Should note that I could only get it to apply the patch by running `$ composer require drupal/upgrade_status --prefer-source`.

Duh. Its missing on purpose, so we can test that. Sending your "fix" for a test run to show that it would fail. Can we have the key missing in some other way, ie. hide the theme?

I understand that it’s probably meant to be that way, but if it causes updatedb (or other things) to fail, it’s broken.

I needed it to work on a site, that’s all the “fix” does; get it to work. I don’t need to test a contrib module, I need my site to work.

It’s merely a stop gap until it’s fixed for those in similar situations to myself.

That makes sense. For me as a maintainer, I am looking for a patch I can commit and ideally hotfix for release. What about altering the info file data at runtime instead? (Which does not affect Upgrade Status' checking given that we read the raw info files).

@namscott, @jklmnop: can you try my patch instead? AFAIS that should help us keep the test and keep the site working at the same time. I checked core/tests/Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php to see how they get around to this problem, but they construct the whole theme on a virtual file system which would not be compatible with the other checks we do in upgrade status.

Thank you for working on this!

The patch applies just fine, but the site still doesn't work. When I go to `admin/reports/updates` or run`drush cr` I get the same exception. Here is the stack trace, if that helps.

The website encountered an unexpected error. Please try again later.

Drupal\Core\Extension\InfoParserException: Missing required key ("base theme") in modules/contrib/upgrade_status/tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.theme/upgrade_status_test_theme.theme, see https://www.drupal.org/node/3066038 in Drupal\Core\Extension\ThemeExtensionList->createExtensionInfo() (line 269 of core/lib/Drupal/Core/Extension/ThemeExtensionList.php).
Drupal\Core\Extension\ExtensionList->doList() (Line: 113)
Drupal\Core\Extension\ThemeExtensionList->doList() (Line: 282)
Drupal\Core\Extension\ExtensionList->getList() (Line: 72)
Drupal\Core\Extension\ThemeHandler->listInfo() (Line: 649)
Drupal\markdown\PluginManager\InstallablePluginManager->setCacheBackend(Object, 'markdown_parser_info') (Line: 37)
Drupal\markdown\PluginManager\ParserManager->__construct(Object, Object, Object, Object, Object) (Line: 262)
Drupal\Component\DependencyInjection\Container->createService(Array, 'plugin.manager.markdown.parser') (Line: 176)
Drupal\Component\DependencyInjection\Container->get('plugin.manager.markdown.parser', 1) (Line: 437)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 240)
Drupal\Component\DependencyInjection\Container->createService(Array, 'paramconverter.markdown') (Line: 176)
Drupal\Component\DependencyInjection\Container->get('paramconverter.markdown', 1) (Line: 437)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 276)
Drupal\Component\DependencyInjection\Container->createService(Array, 'paramconverter_manager') (Line: 176)
Drupal\Component\DependencyInjection\Container->get('paramconverter_manager', 1) (Line: 437)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 240)
Drupal\Component\DependencyInjection\Container->createService(Array, 'access_manager') (Line: 176)
Drupal\Component\DependencyInjection\Container->get('access_manager', 1) (Line: 437)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 240)
Drupal\Component\DependencyInjection\Container->createService(Array, 'redirect.checker') (Line: 176)
Drupal\Component\DependencyInjection\Container->get('redirect.checker', 1) (Line: 437)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 240)
Drupal\Component\DependencyInjection\Container->createService(Array, 'redirect.request_subscriber') (Line: 176)
Drupal\Component\DependencyInjection\Container->get('redirect.request_subscriber') (Line: 136)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.request') (Line: 134)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 716)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Ok, that is unfortunate. Thanks for testing! Let's undo the testing part for now then.

Committed this, will make a release today. Thanks again!

Thanks again for addressing this, @gábor-hojtsy! Sorry it meant removing the test for the time being.

For anyone trying to apply patch #10 to 8.x-3.6, you'll probably have to run $ composer require drupal/upgrade_status --prefer-source since the patch includes a change to upgrade_status_test_theme.info.yml. The patch will not successfully apply to the dist since the file gets versioned via the packager which adds lines to the file. You might also notice that the module shows "Invalid version: Unknown" on the admin/reports/update page too. Not a big deal, just FYI.

I released https://www.drupal.org/project/upgrade_status/releases/8.x-3.7 immediately with the fix, so that should be good to update to. People newly updating should avoid 3.6 entirely :)

excellent! :D

just updated to 8.x-3.7, works perfectly!