So I applied the patch from comment #39 here as specified, but whether I use a Spotify URL or a Soundbutt URL, I am not getting thumbnails. Is this functionality broken or did I apply the wrong patch?

Comments

SoCalErich created an issue. See original summary.

chris matthews’s picture

Category: Bug report » Support request
Status: Active » Postponed (maintainer needs more info)

It looks like the patch in comment #39 from #3080666: oEmbed system doesn't work if thumbnail url does not have a file extension is against the 9.3.x branch. Have you tried the patch in #27 against the 9.2.x branch?

erichhaemmerle’s picture

So I applied patch from #27 and I am still not getting a thumbnail and I do know that this particular SoundCloud entry has a thumbnail. That being said, I am seeing chatter at that Drupal core page about this possibly not working when on a local version of the site for whatever reason? I am on a local version of my site using Docksal, so maybe that might be it? Not sure. I ended up (for now) using the Media Entity SoundCloud module and that seems to be working and pulling in the thumbnail etc. The problem is, this is only SoundCloud which is great, but we may end wanting to do Spotify also.

chris matthews’s picture

@SoCalErich So I did some more testing on this.

- I verified the oEmbed audio resource has a thumbnail

- Before applying the patch from #3080666 #27 ...
I added a SoundCloud url, result = the thumbnail did not come through
I added a Spotify url, result: the thumbnail did not come through

- After applying the patch from #3080666 #27 ...
I added a SoundCloud url, result = the thumbnail did not come through
I added a Spotify url, result = the thumbnail DID come through

So, it seems like the patch from #3080666 #27 works for Spotify, but not for SoundCloud.

chris matthews’s picture

Status: Postponed (maintainer needs more info) » Active

@SoCalErich, after talking with @phenaproxima via Slack, the theory as to why SoundCloud urls are not working is due to the fact that SoundCloud uses dashes in the property names, like thumbnail-url, which contradicts the oEmbed specification. The spec says it’s thumbnail_url.

For example: https://soundcloud.com/oembed?url=https://soundcloud.com/dj-jo-public/lt...

Thank you for your patience on this, a fix is coming ...

chris matthews’s picture

Status: Active » Needs review
StatusFileSize
new6.07 KB

Patch for the SoundClound specific thumbnail issue.

phenaproxima’s picture

Title: Still not getting thumbnails even with core patch. » Thumbnails from SoundCloud are broken
Issue summary: View changes

Re-titling for clarity.

  • phenaproxima committed c2f0c22 on 1.0.x
    Issue #3217929 by Chris Matthews, SoCalErich, phenaproxima: Thumbnails...
phenaproxima’s picture

Status: Needs review » Fixed

Confirmed that adding an empty post-update hook rebuilds the container, thus removing any need for the site owner to run drush cr. Therefore...committed and pushed to 1.0.x! I will roll a 1.0.5 release shortly containing this fix. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.