Currently the Bitbucket deployment dates are not formatted. To be consistent with the other modules they should be formatted in the long core date date format.
In the same code there's also a small bug that triggers a PHP notice if a pipeline hasn't been completed yet:
Notice: Undefined index: completed_on in /var/www/web/modules/contrib/build_hooks/modules/build_hooks_bitbucket/src/Plugin/FrontendEnvironment/BitbucketFrontendEnvironment.php on line 242
* Set up a Bitbucket frontend environment
* Go to the environment
* Launch a new deployment
* The dates are not formatted and a PHP notice is triggered.
A patch will follow
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | show_formatted_dates_in_bitbucket_deployments_table-3212638-7.patch | 6.63 KB | klaasvw |
| #4 | show_formatted_dates_in_bitbucket_deployments_table-3212638-4.patch | 5.83 KB | klaasvw |
Comments
Comment #2
klaasvw commentedThe following patch introduces the following changes in the Bitbucket module:
* Formats the started at and completed at dates in the long core date format.
* Fixes the PHP notice triggered when a pipeline build has no completed_at date
* Fixes some coding standard issues
Comment #4
klaasvw commentedOops, forgot to update the services.yml.
Comment #6
larowlanLooks like the unit test needs updating too, to pass in the extra argument to the constructor
Thanks for contributing
Comment #7
klaasvw commentedSilly me, this time with an updated unit test.
Comment #9
larowlanThanks this will go out as 3.1.4 shortly
Comment #10
larowlanhttps://www.drupal.org/project/build_hooks/releases/3.1.4