Problem/Motivation

The Bitbucket integration using an app password is currently not working because the password is never saved. The reason is that the form uses an incorrect method to check if the password is empty or not (FormStateInterface::get() instead of FormStateInterface::getValue()).

Steps to reproduce

* Create a Bitbucket build hook environment
* Generate a bitbucket app password
* Go to Configuration -> Build Hooks -> Bitbucket Build Hooks Settings
* Enter your username and the app password
* Go to the build hook environment
* The page displayes a 401 Unauthorized error from the Bitbucket API.

Proposed resolution

Patch will follow that uses the correct method.

CommentFileSizeAuthor
#2 bitbucket_app_password_not_saved-3212632-2.patch751 bytesklaasvw

Comments

klaasvw created an issue. See original summary.

klaasvw’s picture

klaasvw commented
StatusFileSize
new bitbucket_app_password_not_saved-3212632-2.patch751 bytes

Patch attached to fix the issue.

klaasvw’s picture

klaasvw commented
Status: Active » Needs review

  • larowlan committed 49d5e3c on 3.x authored by klaasvw 
    Issue #3212632 by klaasvw: Bitbucket app password not saved
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Normally I'd require a test for this but I don't use bitbucket so don't want to hold things up

This will go out as 3.1.2

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

https://www.drupal.org/project/build_hooks/releases/3.1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.