PHP 8.0 compatibility for Views 3

I set up a testbot for PHP 8: https://www.drupal.org/pift-ci-job/2027110

There are some errors noted..

I'm concerned at this one:

fail: [PHP Deprecated] Line 123 of sites/all/modules/views/plugins/views_plugin_query_default.inc:
 Required parameter $options follows optional parameter $base_table

I'm concerned that fixing this will require an API break.

There are some simpler things, e.g.:

exception: [Warning] Line 2433 of sites/all/modules/views/views.module:
Array to string conversion

and:

fail: [Other] Line 120 of sites/all/modules/views/tests/handlers/views_handler_filter_in_operator.test:
Value 2 is equal to value 0.

fail: [Other] Line 122 of sites/all/modules/views/tests/handlers/views_handler_filter_in_operator.test:
Identical result set

fail: [Other] Line 153 of sites/all/modules/views/tests/handlers/views_handler_filter_in_operator.test:
Value 3 is equal to value 5.

fail: [Other] Line 155 of sites/all/modules/views/tests/handlers/views_handler_filter_in_operator.test:
Identical result set

And this one:

exception: [Warning] Line 174 of sites/all/modules/views/tests/views_glossary.test:
Undefined array key 10

And:

fail: [Completion check] Line 54 of sites/all/modules/views/tests/comment/views_handler_argument_comment_user_uid.test:
The test did not complete due to a fatal error.
exception: [Warning] Line 1532 of modules/comment/comment.module:
Attempt to read property "thread" on bool

fail: [Other] Line 443 of sites/all/modules/views/tests/field/views_fieldapi.test:
Take sure that the amount of items are limited.

*cough* Yeah... some of these might be hard to fix without breaking anything.

Some of this is already handled in #3189937: PHP 8: Required parameter after optional deprecation notice.

Ayesh worked on views_plugin_query_default::init() in #3189937.

Ayesh's changes.

exception: [Warning] Line 2433 of sites/all/modules/views/views.module:
Array to string conversion

.. is going to be weird because it isn't clear which variable is causing the problem.

Trying to fix _views_query_tag_alter_condition().

This fixes the problem in _views_query_tag_alter_condition() by converting the nested array to a JSON string and converting it back again after the str_replace().

I rewrote the string replacement using array_walk_recursive().

Does this work?

Ok, so at least it doesn't cause regressions.

Trying to fix the comment tests.

There's something funny with _testMultipleFieldRender(), the "Test delta first last" part fails to render properly with PHP 8. This adds an extra assertion to make sure the output renders.

I've studied the data and there's a problem when "delta_first_last" is enabled on a field, for some reason the query doesn't return any data with PHP 8. I've confirmed this by disabling "delta_first_last" but leaving the other options as-is, the query returned data.

The only place that the option is used is in this code from views_handler_field_field::get_value():

      $new_values = array();
      for ($i = 0; $i < $delta_limit; $i++) {
        $new_delta = $offset + $i;

        if (isset($all_values[$new_delta])) {
          // If first-last option was selected only use the first and last
          // values, otherwise include all values.
          if (!$delta_first_last
            // Use the first value.
            || $new_delta == $offset
            // Use the last value.
            || $new_delta == ($delta_limit + $offset - 1)) {
            $new_values[] = $all_values[$new_delta];
          }
        }
      }

Try again.

Ok fine :p

Side-step.. attempting to fix the failures in cache handling.

To move things along I've committed #19.

The last problems seems to be:

• ViewsCacheTest
  gather_headers
  exception: [Warning] Line 203 of sites/all/modules/views/plugins/views_plugin_cache.inc:
  Array to string conversion
  (repeated a bunch of times)
• viewsHandlerFieldFieldTest
  _testMultipleFieldRender
  fail: [Other] Line 442 of sites/all/modules/views/tests/field/views_fieldapi.test:
  Value NULL is not NULL.
  fail: [Other] Line 447 of sites/all/modules/views/tests/field/views_fieldapi.test:
  Take sure that the amount of items are limited.
  (repeated twice more)

Great work, thank you!

Committed. Thanks Taran2L!