PHP 8: Required parameter after optional deprecation notice [#3189937]

Problem/Motivation

In PHP 8.0, declaring a function required parameter after optional parameters is deprecated. In Views module, \views_plugin_query_default::init has the last $options parameter without a default value, which results in a deprecation notice in PHP 8.0.

Steps to reproduce

Use Drupal 7 (patched for PHP 8) with Views.
Check logs

Proposed resolution

Update \views_plugin_query_default::init function signature (see attached patch)

Remaining tasks

RTBC and commit?

User interface changes

None

API changes

None

Data model changes

None

Comment	File	Size	Author
	php8-views-param-order.patch	826 bytes	ayesh

Issue fork views-3189937

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3189937-php-8-required changes, plain diff MR !3
Check out this branch for the first time

Check out existing branch, if you already have it locally
7.x-3.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 December 2020 at 13:51

Ayesh created an issue. See original summary.

Comment #2

26 December 2020 at 13:56

Ayesh opened merge request !3

Comment #3

damienmckenna

TN, USA

commented 12 January 2021 at 13:04

Parent issue:

» #3118500: Plan for Views 7.x-3.25

So a change like this makes me a little concerned because it's really an API change, but I grepped the ~1,000 D7 modules I have downloaded locally and couldn't find this class extended in any of them. So I think this will be ok.