Problem/Motivation
I have 2 issues related to blazy blurry behaviour:
- The uri for some images is not found, which made a problem for generating the blurry image.
- There is a problem with the logic of encoding some large files using fopen function
Followup logical error after
#3099787: Fix generate image Uri for blurry from the fallback image style when responsive image style is used
Steps to reproduce
Given that we had a
drush image:flush
Then no images under image styles at this time
When we load a page for the first time after the flush of images
And images in the site that using the "Blazy Blurry" option for the media view mode
And we do have a very big originally uploaded with big dimension and file size
Then the blazy blurry image will not load
But when we load the page for the 2nd page
The blazy blurry image for the fallback image style for responsive image style will be present
Then the blazy blurry image will load and show up in the page
Proposed resolution
I suggest generating a new image derivative based on the needed image style to make sure the file exists before creating the new image for blazy blurry style. Also, I think we can improve the encoding way of the image using file_get_contents that may solve the problem with large files.
Remaining tasks
- Patch
- Test round
- Quick fix release
User interface changes
No missing images on the first load of images after a drush image:flush
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3200073-4.patch | 2.55 KB | odai atieh |
| #2 | 3200073-2.patch | 2.31 KB | odai atieh |
Comments
Comment #2
odai atiehComment #3
odai atiehComment #4
odai atiehComment #5
odai atiehComment #6
rajab natshahThank you Odai very much for reporting and troubleshooting and the patch fix
I confirm the issue after
#3107324: Add support for latest blazy loading new logic on responsive image styles
#3095125: Add blurred image effect to be loaded for all Blazy enabled images
#3118035: Fix performance issue on new blurry image (server-side) for each image after the cache rebuild
And then we followed with
#3099787: Fix generate image Uri for blurry from the fallback image style when responsive image style is used
This issue a logical error for not creating a derivative image for the fallback image style from the responsive image style
Thank you for fixing this logical error and bettering up the performance.
Comment #7
rajab natshahComment #9
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #13
rajab natshah