Problem/Motivation

I have 2 issues related to blazy blurry behaviour:

  1. The uri for some images is not found, which made a problem for generating the blurry image.
  2. There is a problem with the logic of encoding some large files using fopen function

Followup logical error after
#3099787: Fix generate image Uri for blurry from the fallback image style when responsive image style is used

Steps to reproduce

Given that we had a drush image:flush
Then no images under image styles at this time
When we load a page for the first time after the flush of images
And images in the site that using the "Blazy Blurry" option for the media view mode
And we do have a very big originally uploaded with big dimension and file size
Then the blazy blurry image will not load
But when we load the page for the 2nd page
The blazy blurry image for the fallback image style for responsive image style will be present
Then the blazy blurry image will load and show up in the page

Proposed resolution

I suggest generating a new image derivative based on the needed image style to make sure the file exists before creating the new image for blazy blurry style. Also, I think we can improve the encoding way of the image using file_get_contents that may solve the problem with large files.

Remaining tasks

  • Patch
  • Test round
  • Quick fix release

User interface changes

No missing images on the first load of images after a drush image:flush

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 3200073-4.patch2.55 KBodai atieh
#2 3200073-2.patch2.31 KBodai atieh

Comments

Odai Atieh created an issue. See original summary.

odai atieh’s picture

StatusFileSize
new2.31 KB
odai atieh’s picture

Status: Active » Needs review
odai atieh’s picture

StatusFileSize
new2.55 KB
odai atieh’s picture

Title: Blazy Blurry: Fix the issue of not exist derivative image and enhance the encoding of base64 image » Fix blazy blurry performance issues of not exist derivative image and enhance the logic of the encoding of base64 image
Issue summary: View changes
rajab natshah’s picture

Title: Fix blazy blurry performance issues of not exist derivative image and enhance the logic of the encoding of base64 image » Fix Blazy Blurry performance issues of not exist derivative image and enhance the logic of the encoding of base64 image
Issue summary: View changes
Related issues: +#3107324: Add support for latest blazy loading new logic on responsive image styles, +#3095125: Add blurred image effect to be loaded for all Blazy enabled images, +#3118035: Fix performance issue on new blurry image (server-side) for each image after the cache rebuild, +#3099787: Fix generate image Uri for blurry from the fallback image style when responsive image style is used

Thank you Odai very much for reporting and troubleshooting and the patch fix
I confirm the issue after
#3107324: Add support for latest blazy loading new logic on responsive image styles
#3095125: Add blurred image effect to be loaded for all Blazy enabled images
#3118035: Fix performance issue on new blurry image (server-side) for each image after the cache rebuild

And then we followed with
#3099787: Fix generate image Uri for blurry from the fallback image style when responsive image style is used

This issue a logical error for not creating a derivative image for the fallback image style from the responsive image style

Given that we had a drush image:flush
Then no images under image styles at this time
When we load a page for the first time after the flush of images
And images in the site that using the "Blazy Blurry" option for the media view mode
And we do have a very big originally uploaded with big dimension and file size
Then the blazy blurry image will not load
But when we load the page for the 2nd page
The blazy blurry image for the fallback image style for responsive image style will be present
Then the blazy blurry image will load and show up in the page

Thank you for fixing this logical error and bettering up the performance.

rajab natshah’s picture

Issue summary: View changes

rajab natshah’s picture

Issue summary: View changes

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue tags: +varbase-8.8.10, +varbase-9.0.0-rc2, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.