Problem/Motivation

When someone submits patches to this module, there is no way for the maintainers to tell if that patch introduces a regression.

Proposed resolution

Add automated tests.

Remaining tasks

  1. Write a patch
  2. Maintainer set up automated testing for issues
  3. Review and feedback
  4. RTBC and feedback
  5. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 interdiff--4-5.txt15.06 KBszhu
#5 3192574-5--add-tests.patch.patch15.55 KBszhu
#4 interdiff--3-4.txt3.79 KBszhu
#4 3192574-4--add-tests.patch5.55 KBszhu
#3 interdiff--2-3.txt3.51 KBszhu
#3 3192574-3--add-tests.patch4.82 KBszhu
#2 3192574-2--add-test.patch1.61 KBszhu

Comments

szhu created an issue. See original summary.

szhu’s picture

szhu commented
Assigned: Unassigned » szhu
Status: Active » Needs work
StatusFileSize
new 3192574-2--add-test.patch1.61 KB

Here is an initial patch, I still have more tests to add so don't commit, please :)

szhu’s picture

szhu commented
StatusFileSize
new 3192574-3--add-tests.patch4.82 KB
new interdiff--2-3.txt3.51 KB

Here is an updated patch, I need to clean it up, I am just posting my progress thus far.

szhu’s picture

szhu commented
StatusFileSize
new 3192574-4--add-tests.patch5.55 KB
new interdiff--3-4.txt3.79 KB

Updated duplicated node test.

szhu’s picture

szhu commented
StatusFileSize
new 3192574-5--add-tests.patch.patch15.55 KB
new interdiff--4-5.txt15.06 KB

Ready for final review.

szhu’s picture

szhu commented
Status: Needs work » Needs review
geoanders’s picture

geoanders commented
Version: 8.x-2.0 » 8.x-3.x-dev

Testing /var/www/html/web/anti_duplicates

SSSSSS 6 / 6 (100%)

Time: 03:06.108, Memory: 6.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 6, Assertions: 6, Skipped: 6.

Remaining self deprecation notices (5)

3x: Declaring ::setUp without a void return typehint in Drupal\Tests\anti_duplicates\FunctionalJavascript\GlobalConfigurationTest is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724
3x in DrupalListener::startTest from Drupal\Tests\Listeners

2x: Declaring ::setUp without a void return typehint in Drupal\Tests\anti_duplicates\FunctionalJavascript\DetectDuplicateNodeTest is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724
2x in DrupalListener::startTest from Drupal\Tests\Listeners

  • geoanders committed d8d887f on 8.x-3.x 
    Issue #3192574 by szhu: Add automated tests
geoanders’s picture

geoanders commented
Status: Needs review » Fixed

Seems to be working on latest branch. All tests have passed. Setup on project to run weekly.

geoanders’s picture

geoanders commented
Status: Fixed » Closed (fixed)