Problem/Motivation

In #3172382: Running "drush upgrade_status:analyze" leads to reflection errors, add conflict to new phpstan versions for now this ^0.12.43 conflict was added as a temporary solution and released with 3.0-beta2. (2020-10-09)
Then on the same day the same temporary solution was shipped with mglaman/phpstan-drupal 0.12.6. Unfortunately the conflict was not removed from drupal/upgrade_status before releasing 3.0.0.

Yesterday nikic/php-parser released a bug fix, then phpstan/phpstan upped its requirements and today 0.12.64 was released and so was mglaman/phpstan-drupal:0.12.7.
mglaman/phpstan-drupal decided to just up the phpstan/phpstan version requirement.

So now drupal/upgrade_status should remove the conflict so that we can again enjoy bug fixes and new features of phpstan/phpstan.

Steps to reproduce

Proposed resolution

drupal/upgrade_status could simply remove the conflict. Or change the phpstan/phpstan conflict to a nikic/php-parser conflict. Or up either the nikic/php-parser version requirement or the mglaman/phpstan-drupal version requirement while removing the phpstan/phpstan conflict.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork upgrade_status-3189376

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Eric_A created an issue. See original summary.

eric_a’s picture

eric_a commented
Issue summary: View changes
eric_a’s picture

eric_a commented
Issue summary: View changes
eric_a’s picture

eric_a commented
Issue summary: View changes

mglaman made their first commit to this issue’s fork.

mglaman opened merge request !1

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review

MR opened

eric_a’s picture

eric_a commented
Status: Needs review » Reviewed & tested by the community

@mglaman, thanks for doing the merge request! Removing the conflict and requiring mglaman/phpstan-drupal:^0.12.7 instead of ^0.12.0 (released with upgrade_status 3.1) would certainly work for me too.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

@Eric_A both changes are required to make sure phpstan-drupal is upgraded, which forces phpstan to upgrade. Otherwise, someone might do something weird and get into an odd install state. How? I have no idea, but I wouldn't leave it to chance 🙂

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Superb, thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Made https://www.drupal.org/project/upgrade_status/releases/8.x-3.1 available, thank @mglaman!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.