Problem/Motivation

A time service was added to 8.3.x in #2717207: Add a time service to provide consistent interaction with time()/microtime() and superglobals.

Core code should be updated to remove deprecated uses of REQUEST_TIME and time() and others.

For more informations, see the change record.

Proposed resolution

Splitting this up into manageable chunks (#57 by @mpdonadio)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 3188273-11.patch7.74 KBjrockowitz
#8 3188273-8.patch8.13 KBjrockowitz
#6 3188273-6.patch8.9 KBPooja Ganjage
#4 3188273-4.patch8.9 KBPooja Ganjage
#2 webform-replace_use_time_with_service-3188273-1.patch11.9 KBandrewsizz

Comments

AndrewsizZ created an issue. See original summary.

andrewsizz’s picture

andrewsizz commented
Assigned: andrewsizz » Unassigned
Status: Needs work » Needs review
StatusFileSize
new webform-replace_use_time_with_service-3188273-1.patch11.9 KB

Status: Needs review » Needs work

The last submitted patch, 2: webform-replace_use_time_with_service-3188273-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3188273-4.patch8.9 KB

Hi,

Creating a patch for solving the issue that raised in #2 comment.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3188273-6.patch8.9 KB

Creating Updated patch as PHPLint failed.

Status: Needs review » Needs work

The last submitted patch, 6: 3188273-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3188273-8.patch8.13 KB

Minor tweak to the patch to make it backward compatible.

Status: Needs review » Needs work

The last submitted patch, 8: 3188273-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz commented

It seems almost impossible to fix WebformEntityReferenceFormatterBase in 8.x-5.x while in 6.x this should be easy to fix.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3188273-11.patch7.74 KB

This is the best solution for 8.x-5.x

  • jrockowitz authored a3385d1 on 8.x-5.x 
    Issue #3188273 by Pooja Ganjage, jrockowitz, AndrewsizZ: Replace uses of...

  • jrockowitz authored a3385d1 on 6.x 
    Issue #3188273 by Pooja Ganjage, jrockowitz, AndrewsizZ: Replace uses of...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.