This issue is part of our sprint: https://groups.drupal.org/node/536206

As per the TODO description:
@TODO: We have to load these options from this field settings to show only selected types.

We need to make sure to read the options of the Saudi Identity field directly from field settings instead of redefining the list of options.
On this line 69 We can see the list of options are defined as PHP array. We should find a way to read this array from the same source of field settings which is defined on line 38.

We may find a way to define this list as a new method in the SaudiIdentityItem class.

Any suggestions are welcomed.

Comments

samaphp created an issue. See original summary.

  • samaphp committed 99e0211 on 8.x-2.x
    Refactor field setting options to read from the default settings. #...
samaphp’s picture

Status: Active » Needs review

The field settings has been added in defaultFieldSettings() as a centralized place for field options.

This issue has been resolved. please review guys. Thanks

samaphp’s picture

Assigned: Unassigned » samaphp
hamadm’s picture

Tested

hamadm’s picture

Status: Needs review » Reviewed & tested by the community
3ssom’s picture

Status: Reviewed & tested by the community » Fixed
3ssom’s picture

Status: Fixed » Closed (fixed)