Azure/AWS: Take into account CONFIG command may not work

#3 patch is not working if you applied it on latest redis module.
So above is reworked patch.

I have also experienced this problem on Platform.sh sites using Redis 6.0.

#9: The merge request does not apply for me either when testing with the current latest release, 8.1.5.

The patch in #7 does apply, solves the problem in my case and the code looks sound to me. I will mark this as RTBTC.

This patch from #7 has been rerolled so that if you have have the patch from https://www.drupal.org/project/redis/issues/2900947 it applies.

Extended the patch from #11 so that if maxmemory policy is not returned, there is not PHP warning generated.

Further experiences with AWS indicate that ->info() throws an error for certain AWS ElastiCache configurations and also there is a second ->config() that needs attention too.

Confirmed the second ->config() throws an error on the default AWS elasticache configuration.
I'm working on this.

Added try, catch for the error thrown by the second ->config() on the reports page.

Still for if you have have the patch #49 from https://www.drupal.org/project/redis/issues/2900947 applied.

This is working for me now against a default config Elasticache redis cluster.

@eelkeblok @t-lo the patches provided at #16 and in the issue fork 3173988-azureaws-take-into no longer apply correctly in 1.5.0

Both patches need to be re-rolled.

Moreover, I suggest to change the use of CONFIG to INFO redis, which gives the same information and usually does not have the issue of being restricted by the hosting providers. It is also supported in both libraries, phpredis and predis.

https://github.com/phpredis/phpredis#info
https://github.com/ProgerXP/predis-doc/blob/master/Commands.md#infosection

Change patch #16
Aplied for my

Change patch #20

Small fix to patch #20 that gave this error
Warning: Undefined array key "used_memory_human" in Drupal\redis\Controller\ReportController

Hi patch #21 works like a charm with AWS

#21 works for me

Change patch #21

Small fix to patch #21 that gave me this error

Warning: Trying to access array offset on value of type bool in Drupal\redis\Controller\ReportController->overview() (line 176 of modules/contrib/redis/src/Controller/ReportController.php).

watchdog_exception() is deprecated and removed in D11.

Adding a patch compatible with the 1.8 version of the module, deprecating watchdog_exception when possible.

Having the same issue with version 1.7.0 on AWS, the patch #21 is working for me as expected.

Sorry for making more noise. Here's a simplified approach that rely on INFO command instead of CONFIG.

patch #26 worked for me on latest version module, thanks! greetings,

#21 still works like a charm with AWS Redis cache. thanks!

Client PhpRedis
Version 6.2.6
Drupal 9.5.11
Redis 8.x-1.7

Please can the patch at comment #28 please be added to a production release. It is necessary to allow the module to work with Azure Cache for Redis. Tested successfully from Azure App Service with Drupal 10.3.

Thanks for the fix. I can confirm the patch at #28 works for me in an Azure hosted environment with Drupal `v10.4.5` using Redis `v1.9.0` and Predis `v1.1.10`. I would be very interested in seeing it merged so I don't have to manually track this issue anymore.

Patch at #28 works for me with AWS Elasticache-Redis with Drupal 10.4.5, drupal/redis 1.9.0, and predis 2.4.0.

(I also had to apply a patch from Support TLS for Predis to enable this module to provide the "tls" scheme to predis and apparently I'm following @mitokens around on this.)

I believe this has been addressed by #3537948: Abstract info-collection RedisController to deal with special environments, if not, feel free to reopen.

Yes, but it only calls it if the information isn't already available. stats/info/config output seems to vary wildly between different, it is very much possible that while config() might not work on Azure, info() might contain that somewhere else. There also are patches here wit different approaches. if necessary we can extend the logic with a try/catch, removing it completely does not seem like a viable option.

I saw that comment and was surprised, we've been using redis on platform.sh since 2015 and never needed this.

Reopening. I updated to Redis 8.0 on Upsun (Platform SH) and I am now getting this error. It seems this is a security recommendation from Redis when running in a hosted environment, to prevent customers from reconfiguring Redis (ref. https://redis.io/docs/latest/operate/oss_and_stack/management/security/#...).

I created a new MR because the previous one is outdated now that #3537948: Abstract info-collection RedisController to deal with special environments is in.

Thanks to the improvements made in that ticket, the fix is now very trivial.

I reviewed the MR 77 and successfully tested it on Upsun.

I'd appreciate a second MR against 2.x which moved that code, that will make it easier for me to merge this.

Opened a MR against 2.x. I did not test this out manually, the porting was quite straightforward.

Thanks.

Accessing $memory_config lines outside of the try looks a bit strange, but if we actually fall back to an empty string instead of NULL then we don't need the ?? '' fallback in the ReportController, so lets keep and change that, otherwise looks good to me.

Thanks for the suggestion, both MRs are updated.

Merged the 8.x-1.x MR but noticed that the 2.x MR seems to be missing the change in the Relay client. Maybe that bit could be in a trait or so to avoid the duplication, but off topic for this and might also have some minor differences (and will definitely have that with the cluster clients)

I missed that there is now a third client. Added the fix for this one also, sorry for keeping you busy!

Thanks, merged.