------ --------------------------------------------------------------------
Line entity_extra_field.module
------ --------------------------------------------------------------------
105 PHPDoc tag @param has invalid value ($build
An array of elements to attach the extra field.): Unexpected token
"$build", expected type at offset 106
105 PHPDoc tag @param has invalid value ($type
The display type, (e.g. view, form).): Unexpected token "$type",
expected type at offset 48
------ --------------------------------------------------------------------
------ -------------------------------------------------------------------------
Line modules/entity_extra_field_ui/src/Plugin/Derivative/MenuLinksAction.php
------ -------------------------------------------------------------------------
37 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line modules/entity_extra_field_ui/src/Plugin/Derivative/MenuLinksTask.php
------ -----------------------------------------------------------------------
37 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/Controller/EntityExtraFieldListBuilder.php
------ -----------------------------------------------------------------------
60 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
84 Call to an undefined method
Drupal\Core\Entity\EntityInterface::getFieldTypeLabel().
85 Call to an undefined method
Drupal\Core\Entity\EntityInterface::getDisplayType().
137 Method
Drupal\entity_extra_field\Controller\EntityExtraFieldListBuilder::get
BaseEntityBundleType() should return
bool|Drupal\Core\Config\Entity\ConfigEntityInterface but returns
null.
------ -----------------------------------------------------------------------
------ --------------------------------------------------------------------
Line src/Entity/EntityExtraField.php
------ --------------------------------------------------------------------
326 Method Drupal\entity_extra_field\Entity\EntityExtraField::exists()
should return int but returns bool.
360 If condition is always true.
------ --------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/Entity/EntityExtraFieldInterface.php
------ -----------------------------------------------------------------------
156 PHPDoc tag @param has invalid value ($type
The type of attachment (library, drupalSettings, etc)): Unexpected
token "$type", expected type at offset 50
170 PHPDoc tag @param has invalid value ($name
The entity machine name.): Unexpected token "$name", expected type at
offset 60
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/ExtraFieldTypePluginBase.php
------ -----------------------------------------------------------------------
69 PHPDoc tag @param has invalid value ($plugin_definition
The plugin definition.): Unexpected token "$plugin_definition",
expected type at offset 180
69 PHPDoc tag @param has invalid value ($plugin_id
The plugin identifier.): Unexpected token "$plugin_id", expected type
at offset 127
96 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
268 PHPDoc tag @param has invalid value ($text
The text that contains the token.): Unexpected token "$text",
expected type at offset 57
289 PHPDoc tag @param has invalid value ($entity_bundle
The entity bundle name.): Unexpected token "$entity_bundle", expected
type at offset 113
289 PHPDoc tag @param has invalid value ($entity_type_id
The entity type identifier.): Unexpected token "$entity_type_id",
expected type at offset 50
342 PHPDoc tag @param has invalid value ($entity_bundle
The entity bundle name.): Unexpected token "$entity_bundle", expected
type at offset 123
342 PHPDoc tag @param has invalid value ($entity_type_id
The entity type identifier.): Unexpected token "$entity_type_id",
expected type at offset 60
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/Form/EntityExtraFieldForm.php
------ -----------------------------------------------------------------------
82 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
318 PHPDoc tag @param has invalid value ($plugin_id
The field type plugin identifier.): Unexpected token "$plugin_id",
expected type at offset 67
356 Call to an undefined method
Drupal\Component\Plugin\PluginManagerInterface::getDefinitionsForCont
exts().
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/Plugin/ExtraFieldType/ExtraFieldBlockPlugin.php
------ -----------------------------------------------------------------------
76 PHPDoc tag @param has invalid value ($plugin_definition
The plugin definition.): Unexpected token "$plugin_definition",
expected type at offset 183
76 PHPDoc tag @param has invalid value ($plugin_id
The plugin identifier.): Unexpected token "$plugin_id", expected type
at offset 130
99 Property
Drupal\entity_extra_field\Plugin\ExtraFieldType\ExtraFieldBlockPlugin
::$blockManager (Drupal\Core\Entity\EntityTypeManagerInterface) does
not accept Drupal\Core\Block\BlockManagerInterface.
113 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
316 Result of || is always true.
319 Unreachable statement - code above always terminates.
------ -----------------------------------------------------------------------
------ ------------------------------------------------------------------
Line src/Plugin/ExtraFieldType/ExtraFieldViewsPlugin.php
------ ------------------------------------------------------------------
57 Variable $instance in PHPDoc tag @var does not match assigned
variable $view.
102 Variable $view in PHPDoc tag @var does not exist.
103 Cannot call method getDependencies() on
Drupal\Core\Entity\EntityInterface|true.
263 PHPDoc tag @param has invalid value ($view_name
The view name.): Unexpected token "$view_name", expected type at
offset 46
------ ------------------------------------------------------------------
------ --------------------------------------------------------------------
Line templates/entity_extra_field.theme
------ --------------------------------------------------------------------
13 Function template_preprocess_entity_extra_field not found while
trying to analyse it - autoloading is probably not configured
properly.
22 Function entity_extra_field_class_string not found.
43 Function entity_extra_field_class_string not found while trying to
analyse it - autoloading is probably not configured properly.
------ --------------------------------------------------------------------
[ERROR] Found 36 errors
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3172599-11.patch | 18.35 KB | Pooja Ganjage |
| #9 | 3172599-9.patch | 18.38 KB | Pooja Ganjage |
| #8 | entity_extra_field-D9-3172599-8.patch | 898 bytes | darksnow |
| #5 | 3172599-5.patch | 15.75 KB | msuthars |
| #3 | 3172599-3.patch | 10.69 KB | msuthars |
Comments
Comment #2
msutharsComment #3
msutharsFixed the issues. Please review the patch.
Comment #4
msutharsComment #5
msutharsFixed some dependency injection related changes. Please review the patch.
Comment #6
meena.bisht commentedComment #7
meena.bisht commentedStill found some issues .
------ -------------------------------------------------------------------------
Line modules/entity_extra_field_ui/src/Plugin/Derivative/MenuLinksAction.php
------ -------------------------------------------------------------------------
37 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line modules/entity_extra_field_ui/src/Plugin/Derivative/MenuLinksTask.php
------ -----------------------------------------------------------------------
37 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -----------------------------------------------------------------------
------ -------------------------------------------------------
Line src/Controller/EntityExtraFieldListBuilder.php
------ -------------------------------------------------------
60 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------
------ ---------------------------------
Line src/Entity/EntityExtraField.php
------ ---------------------------------
360 If condition is always true.
------ ---------------------------------
------ -------------------------------------------------------
Line src/ExtraFieldTypePluginBase.php
------ -------------------------------------------------------
97 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------
------ -----------------------------------------------------------------------------
Line src/ExtraFieldTypePluginManager.php
------ -----------------------------------------------------------------------------
16 Plugin manager has cache backend specified but does not declare cache tags.
------ -----------------------------------------------------------------------------
------ -------------------------------------------------------
Line src/Form/EntityExtraFieldForm.php
------ -------------------------------------------------------
94 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------
------ -------------------------------------------------------
Line src/Plugin/ExtraFieldType/ExtraFieldBlockPlugin.php
------ -------------------------------------------------------
113 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ -------------------------------------------------------
------ ----------------------------------------------------------
Line src/Plugin/ExtraFieldType/ExtraFieldEntityLinkPlugin.php
------ ----------------------------------------------------------
84 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
------ ----------------------------------------------------------
------ -----------------------------------------------------
Line src/Plugin/ExtraFieldType/ExtraFieldViewsPlugin.php
------ -----------------------------------------------------
103 If condition is always true.
------ -----------------------------------------------------
------ -----------------------------------------------------------------------------------------------------------------------------------------
Line templates/entity_extra_field.theme
------ -----------------------------------------------------------------------------------------------------------------------------------------
13 Function template_preprocess_entity_extra_field not found while trying to analyse it - autoloading is probably not configured properly.
22 Function entity_extra_field_class_string not found.
43 Function entity_extra_field_class_string not found while trying to analyse it - autoloading is probably not configured properly.
------ -----------------------------------------------------------------------------------------------------------------------------------------
[ERROR] Found 13 errors
Comment #8
darksnowOn testing the newest patch above, it causes the module to crash.
This is due to the line
$this->$contextHandler = $content_handler;which has an extra $ sign.Running this module through PHPCS gives a very long list of issues which I think are out of scope for the D9 upgrade. According to the upgrade_status module, all that's needed is to mark this module as compatible with D9 in the info file, so I've attached a very small patch to do just that, and nothing else.
The work above needs to be done, and is great work, but as general maintenance of this module, not for the D9 upgrade.
Comment #9
Pooja Ganjage commentedHi,
Creating a patch for this issue.
Please review the patch.
Thanks.
Comment #10
Pooja Ganjage commentedComment #11
Pooja Ganjage commentedUpdated Patch.
Comment #12
droath commentedThanks for the patch, but I'm unable to apply the patch against the latest dev release. Are you able to reroll the patch?
Comment #13
droath commentedComment #15
droath commentedThanks for the patches, I was able to review and fix the unresolved issues. Code has been merged into the 2.x branch. Which is the branch that will support Drupal 9.