When using D9, the cookiebot config page is not rendering because of a call to a deprecated function - path.alias_manager

This small patch fixes that.

CommentFileSizeAuthor
#11 3172479_11.patch3.73 KBmpp
#7 3172479-6.patch2.68 KBk-mo
#5 3172479-5.patch2.36 KBk-mo
#4 3172479-4.patch2.13 KBmarkconroy
#2 3172479-2.patch2.13 KBmarkconroy

Issue fork cookiebot-3172479

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

markconroy created an issue. See original summary.

markconroy’s picture

markconroy commented
Status: Active » Needs review
StatusFileSize
new 3172479-2.patch2.13 KB

Uploading patch, setting to "needs review" so the CI Bots can check it.

Status: Needs review » Needs work

The last submitted patch, 2: 3172479-2.patch, failed testing. View results

markconroy’s picture

markconroy commented
StatusFileSize
new 3172479-4.patch2.13 KB

This patch is just against the alpha-7 tag, so it can be used right now while waiting on a new version of the module to be released. This is not the patch that should be used for the next version of the module.

k-mo’s picture

k-mo commented
StatusFileSize
new 3172479-5.patch2.36 KB

new patch attached for latest version

k-mo’s picture

k-mo commented
k-mo’s picture

k-mo commented
StatusFileSize
new 3172479-6.patch2.68 KB
abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented
Status: Needs work » Reviewed & tested by the community

We're using this patch in production; setting to RTBC.

mpp made their first commit to this issue’s fork.

mpp opened merge request !4

mpp’s picture

mpp commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3172479_11.patch3.73 KB

The patch in #7 was missing one instance of 'path.alias_manager':

    $url_alias_path = \Drupal::service('path.alias_manager')->getAliasByPath($path);
mpp’s picture

mpp commented

Status: Needs review » Needs work

The last submitted patch, 11: 3172479_11.patch, failed testing. View results

ras-ben’s picture

ras-ben commented
Status: Needs work » Reviewed & tested by the community

#11 seems to do the trick for me.
I have no idea why it says it failed the tests - when I view the results, it seems like everything is green?

Reviewed OK from here.

  • markconroy committed 3dafeb5 on 8.x-1.x authored by mpp 
    Issue #3172479 by mpp, markconroy, mojo4444: Switch path.alias_manager...
markconroy’s picture

markconroy commented

This patch looks good to me. Thanks for working on this everyone.

markconroy’s picture

markconroy commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.