Running "drush upgrade_status:analyze" leads to reflection errors, add conflict to new phpstan versions for now [#3172382]

Comment	File	Size	Author
#8	3172382.patch	354 bytes	Gábor Hojtsy

Comment #1

22 September 2020 at 11:08

r81d3r created an issue. See original summary.

Log in or register to post comments

Comment #2

r81d3r CreditAttribution: r81d3r as a volunteer commented 22 September 2020 at 11:28

Issue summary:

View changes

Log in or register to post comments

Comment #3

r81d3r CreditAttribution: r81d3r as a volunteer commented 22 September 2020 at 14:13

I solved this problem on my setup with a complete reinstallation of phpunit and drupal/upgradestatus the following way:

drush pmu upgrade_status
composer remove drupal/upgrade_status
composer remove phpunit/phpunit --dev
composer require phpunit/phpunit:"^6.5 || ^7" --dev && composer update --with-dependencies
composer require drupal/upgrade_status && composer update --with-dependencies
drush cr && drush en upgrade_status && drush cr
drush upgrade_status:analyze --all

after upgrade_status runs trough no warnings have been detected

edit: could someone explain to me what this warnings are about?

Log in or register to post comments

Comment #4

Arlina CreditAttribution: Arlina at Chapter Three commented 23 September 2020 at 21:11

Experiencing similar errors. Found out the issue started happening after the latest release of phpstan/phpstan 0.12.43. Issue has been reported on the mglaman/drupal-check project: https://github.com/mglaman/drupal-check/issues/186

Quick fix for a project using this would be to manually require the previous version for the time being:
composer require phpstan/phpstan:"0.12.42"

Log in or register to post comments

Comment #5

mglaman

English

WI, USA

CreditAttribution: mglaman as a volunteer commented 6 October 2020 at 20:48

This is a bug in PHPStan Drupal's compact with PHPStan, as @Arlina has noted.

Log in or register to post comments

Comment #6

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 7 October 2020 at 12:55

Should we have a composer conflict added?

Log in or register to post comments

Comment #7

mglaman

English

WI, USA

CreditAttribution: mglaman as a volunteer commented 7 October 2020 at 15:21

I think a conflict would be the best approach until I can set aside time to fix the autoloading in PHPStan Drupal

Log in or register to post comments

Comment #8

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 8 October 2020 at 09:27

Status:

Active

» Needs review

File	Size
3172382.patch	354 bytes

So this is what we need I guess.

Log in or register to post comments

Comment #9

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 8 October 2020 at 09:52

Title:

Running "drush upgrade_status:analyze" leads to reflection errors

» Running "drush upgrade_status:analyze" leads to reflection errors, add conflict to new phpstan versions for now

Log in or register to post comments

Comment #10

8 October 2020 at 09:52

Gábor Hojtsy committed 3c8cb76 on 8.x-3.x

Issue #3172382 by Gábor Hojtsy, r81d3r, mglaman, Arlina: Running "drush...

Log in or register to post comments

Comment #11

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 8 October 2020 at 09:53

Version:	8.x-2.9	» 8.x-3.x-dev
Status:	Needs review	» Fixed

Fixed for now. Will tag a new release of 3.x soon and 2.x soon.

Log in or register to post comments

Comment #12

8 October 2020 at 09:53

Gábor Hojtsy committed 79b1dc7 on 8.x-2.x

Issue #3172382 by Gábor Hojtsy, r81d3r, mglaman, Arlina: Running "drush...

Log in or register to post comments

Comment #13

mglaman

English

WI, USA

CreditAttribution: mglaman as a volunteer commented 8 October 2020 at 21:29

Good call. I'm trying to figure out what broke phpstan-drupal in nikic/php-parser to 4.10.0 or ondrejmirtes/better-reflection to 4.3.29 for PHPStan 0.12.43.