Problem: we use PHPStan to analyze our code base. It does not know that the interface methods can produce NULL values and then complains when we check for NULL.

Solution: fix the doc comments to indicate that NULL can be returned.

CommentFileSizeAuthor
#2 profile-null-3170218-2.patch992 bytesklausi

Comments

klausi created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review
StatusFileSize
new profile-null-3170218-2.patch992 bytes

Patch.

hideaway’s picture

hideaway commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! RTBC

bradjones1’s picture

bradjones1
Primary language English
commented

I came to the issue queue to submit the same; I'll second the RTBC.

  • mglaman committed 71742fa on 8.x-1.x authored by klausi 
    Issue #3170218 by klausi, hideaway, bradjones1: Fix...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed for the next quick release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.