Problem/Motivation:
The new label should be translatable using the core module config_translation.

Proposed Solution:
In the file field_label.schema.yml the property label_value is defined as type string, If instead of being defined as type string, this property was defined as a type label, the new label could be translated from the interface of core module config_translation.

CommentFileSizeAuthor
translatable_label.patch471 bytesaarnau

Comments

aarnau created an issue. See original summary.

justcaldwell’s picture

Status: Active » Needs review

Great idea and thank you for the patch! I expect to tag a new release in the next couple days -- I'll be sure this is committed.

Setting to Needs review to remind me!

justcaldwell’s picture

Hi @aarnau -- I applied your locally, but I'm afraid I don't know enough about translations to fully test the change. I've enabled config_translation, language, etc., and can successfully translate the initial label value for a test field, but I cannot figure out how/where I would provide a translation for the new label value.

Can you provide any insight? Thanks!

  • justcaldwell committed 1763831 on 8.x-1.x authored by aarnau
    Issue #3157642 by aarnau: The new label should be translatable
    
justcaldwell’s picture

Status: Needs review » Fixed

Committed and pushed. Thanks, again.

Note: As far as I can tell, you still can't easily translate the new label value until #2546212: Entity view/form mode formatter/widget settings have no translation UI lands (or apply that patch).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.