With the automated rector patch provided in https://www.drupal.org/project/restrict_by_ip/issues/3141537, the module appears to be working correctly for me in Drupal 9. However, the patch does not add the necessary core_version_requirement line to the info.yml file. Applying this patch in combination with the automated rector patch should produce a working D9 module.

CommentFileSizeAuthor
#6 interdiff-3156173-5-6.txt933 bytesmanuel.adan
#6 restrict_by_ip-d9_compatibility-3156173-6.patch39.31 KBmanuel.adan
#5 interdiff-3156173-4-5.txt2.14 KBmanuel.adan
#5 restrict_by_ip-d9_compatibility-3156173-5.patch39.92 KBmanuel.adan
#4 interdiff-3156173-3-4.txt38.18 KBmanuel.adan
#4 restrict_by_ip-d9_compatibility-3156173-4.patch39.27 KBmanuel.adan
#3 restrict_by_ip-d9_compatibility-3156173-3.patch5.18 KBmanuel.adan
core_version_requirement.patch380 byteswrd

Issue fork restrict_by_ip-3156173

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

wrd created an issue. See original summary.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Active » Reviewed & tested by the community
manuel.adan’s picture

manuel.adan
Location 🌌
commented
Title: Add core_version_requirement for D9 » Drupal 9 compatibility
Category: Feature request » Task
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new restrict_by_ip-d9_compatibility-3156173-3.patch5.18 KB

There were also some deprecations to review. Simple tests still to be moved to phpunit, drupalci.yml added according to CR indications, anyway it fail due to #3114594.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
StatusFileSize
new restrict_by_ip-d9_compatibility-3156173-4.patch39.27 KB
new interdiff-3156173-3-4.txt38.18 KB

Test converted from simpletest to PHPUnit.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
StatusFileSize
new restrict_by_ip-d9_compatibility-3156173-5.patch39.92 KB
new interdiff-3156173-4-5.txt2.14 KB
  • removes the "core: 8.x" no longer required
  • backs RequestEvent to the deprecated in Symfony 4.3 GetResponseEvent to maintain D8 compatibility, should have at least one release compatible both with D8 and 9
  • simplyfies the current IP CIDR initialization on web base test class
manuel.adan’s picture

manuel.adan
Location 🌌
commented
StatusFileSize
new restrict_by_ip-d9_compatibility-3156173-6.patch39.31 KB
new interdiff-3156173-5-6.txt933 bytes

Despite tests run fine on a local D8.9 fresh installation:

PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing 
.................................................                 49 / 49 (100%)

Time: 2.1 minutes, Memory: 901.00 MB

OK (49 tests, 308 assertions)

HTML output was generated

it seems that the current IP CIDR initialization make automated tests to fail. Change reverted.

  • manuel.adan committed f91edc1 on 8.x-4.x 
    Issue #3156173 by manuel.adan, wrd: Drupal 9 compatibility
manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.