Comments

abu-zakham created an issue. See original summary.

abu-zakham’s picture

abu-zakham’s picture

Project: Vartheme Claro » Varbase Theme (Bootstrap 4 - SASS)
Version: 8.1.x-dev » 8.x-6.x-dev
rajab natshah’s picture

Issue summary: View changes
abu-zakham’s picture

Assigned: abu-zakham » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.9 KB
rajab natshah’s picture

Thank abu-zakham for reporting and patching!

Not very sure

Better to have a library named moderation-control-layout-builder for example. And only load when we have both varbase_workflow + varbase_layout_builder

If we do have more custom variables we may run into a more complicated update process for old custom themes.
easier way to extend library ( or add a widget component in the components folder for the moderation-control-layout-builder library )
We may use a ready class by bootstrap 4 in the twig template file. to follow the custom style for that ready class by bootstrap 4 )

mohammed j. razem’s picture

Status: Needs review » Needs work

I agree.
One of the most performance taxing issues (according to Google Lighthouse) is Unused CSS and JS in pages.

https://web.dev/unused-css-rules/

So if we can limit the CSS to be loaded only when needed, would be much better.

abu-zakham’s picture

StatusFileSize
new690 bytes
new138.73 KB

I've used bootstrap 4 classes, card for wrapper and p-3 for wrapper padding and w-25 for state field width.

abu-zakham’s picture

Issue summary: View changes
Status: Needs work » Needs review
abu-zakham’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Needs review » Needs work
rajab natshah’s picture

Title: Styling moderation control in Layout builder » Styling moderation control layout editing page
rajab natshah’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new165.3 KB
rajab natshah’s picture

Status: Needs review » Active
rajab natshah’s picture

Title: Styling moderation control layout editing page » Styling moderation status control layout editing page
rajab natshah’s picture

Title: Styling moderation status control layout editing page » Style the moderation status control at the layout editing page
rajab natshah’s picture

StatusFileSize
new7.92 KB

  • RajabNatshah committed 367c0c3 on 8.x-6.x
    Issue #3151514 by abu-zakham, RajabNatshah, Mohammed J. Razem: Style the...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.7, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah’s picture

Title: Style the moderation status control at the layout editing page » Style the Moderation state control at the layout editing page

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes