Resolve any admin CRUD problem in relation with order and shipments - Infinite loop on shipment edit > CurrencyHelper::isAdminOrder()

This is introduced in 3099944 because the order object is not available, but order id in some cases.

I see that commerce_shipment is extending admin route providers now, and therefor shipment edit form is admin route.
Think it was not before when have chosen to go with the current approach.

This needs to be completely removed, and for any check on admin we should take into consideration only the admin path defined by routes, it is most cleanest way to do it.

There is no point in adding more specific checks for each case

  /**
   * Check admin route.
   */
  public function checkAdminRoute() {
    // Get current route. Skip admin path.
    return \Drupal::service('router.admin_context')->isAdminRoute($this->routeMatch->getRouteObject());
  }

Hi,

I used the $order we get in the CurrencyOrderRefresh event subscriber class. Its working on my local, and it doesn't use the database query directly.

Please check and give feedback, if any.

Thanks

Hi,

Previous patch is missing one check, added that in this new patch.

Thanks

There is a simpler way it seems to fix this

Adjusting the title to more reflect upcoming patch

Initial patch attached.

There were a few more changes, but added test coverage for commerce admin orders and shipment admin handling.

We in fact are running core tests, wrapped with injected different currentCurrency than core tests.
That should confirm that we are not influencing any admin CRUD action.

\Drupal\Tests\commerce_order\FunctionalJavascript\OrderAdminTest
\Drupal\Tests\commerce_shipping\FunctionalJavascript\ShipmentAdminTest

So three tests cases are still going to fail

Removing some debug lines from shipping. (that is the reason for failing those)

Now we are down to two failing tests from core

testCreateOrder
testAdminOrderView

Needed to rework path changes, it seems for now it is easiest just ignore /admin completely.
Until 2.x overall rewrite, this ought to be enough.

With core commerce/shipping tests passing with injected different current currency value.

Nice!

All tests are passing, ours for cart/checkout, and core commerce/shipping for creating orders/shipments through admin UI with injected different currentCurrency.

Most definitely committing this today 🥳 .

Committed.

This is the last big change before moving to 2.x version of the module
2.x plan