Views table settings exposes "Details" field even when empty

Me too on 8.9.0. What the heck is this?

This could be solution.

Looks like we missed something in #3119279: views-view-table.html.twig template directly uses details without render array and polyfills

Did a little debugging to figure out why this would be. This happens when $variables['caption_needed'] gets set to true for a different reason then the summary or description.

So the fix in #4 makes sense, maybe with a little tweak?

+++ b/core/modules/views/views.theme.inc
@@ -664,19 +664,21 @@ function template_preprocess_views_view_table(&$variables) {
+  if (!empty($handler->options['description'])) {
...
+      '#title' => $handler->options['summary'],

shouldn't we also check $handler->options['summary']

Here we go. Added a test and updated the fix a bit.

This condition exists in the Twig template before #3119279: views-view-table.html.twig template directly uses details without render array and polyfills and it seems we somehow missed it:

+++ b/core/modules/views/templates/views-view-table.html.twig
@@ -47,15 +48,8 @@
-    {% if (summary is not empty) or (description is not empty) %}

+1 to the change and thank you for adding test coverage for this.

A) Sorry we missed this! Ugh. 🤦‍♂️

B) Happy to report #7 applies cleanly to 9.1.x branch, too. Should be a simple commit + cherry-pick scenario.

C)

+++ b/core/modules/views/views.theme.inc
@@ -664,19 +664,21 @@ function template_preprocess_views_view_table(&$variables) {
+  if (!empty($handler->options['summary']) || !empty($handler->options['description'])) {
...
+      '#title' => $handler->options['summary'],
...
+          'description' => $handler->options['description'],

We use both, shouldn't we test that both have a value? Don't we want && here?

I tested via the Views UI -- looks like if you define a summary title, and leave a blank description, you at least end up with an empty string saved in the options, so there won't be a PHP warning with an undefined array key for description. You just get an empty <details>. I suppose if someone wanted to have just a summary and no description, we should let them:

Also tried saving a description, then going back to clear out the title, and saving the view. You end up with a "raw" <details>, without the <summary>, but it does work:

Convinced myself this is RTBC. ;) +1.

Thanks/sorry,
-Derek

Also, this bug has nothing (specifically) to do with the grouping setting. Other table settings will trigger it, such as "Caption for the table". Giving this a more generic title for the commit and history.

Thanks,
-Derek

Patch in #7 works for me

Ran into this today, thanks for patching and adding a test @Lendude! RTBC++

When there's caption the if statement is always true and renders a tag, applied the patch in #7 and it works fine, thanks for the work!

Patch in #7 works for me too.

Patch #7 is RTBC according to me!

+++ b/core/modules/views/views.theme.inc
@@ -664,19 +664,21 @@ function template_preprocess_views_view_table(&$variables) {
+  if (!empty($handler->options['summary']) || !empty($handler->options['description'])) {
+    $variables['summary_element'] = [
+      '#type' => 'details',
+      '#title' => $handler->options['summary'],
+      // To ensure that the description is properly escaped during rendering,
+      // use an 'inline_template' to let Twig do its magic, instead of 'markup'.
+      'description' => [
+        '#type' => 'inline_template',
+        '#template' => '{{ description }}',
+        '#context' => [
+          'description' => $handler->options['description'],
+        ],
       ],
-    ],
-  ];
+    ];
+  }
   $variables['caption_needed'] |= !empty($variables['summary']) || !empty($variables['description']);

Can move the $variables['caption_needed'] assignment into the if and reduce complexity and type changes by doing:
$variables['caption_needed'] = TRUE;

See https://3v4l.org/rIGLZ

Here I have addressed comment #18.

+++ b/core/modules/views/views.theme.inc
@@ -678,8 +678,8 @@ function template_preprocess_views_view_table(&$variables) {
+    $variables['caption_needed'] |= !empty($variables['summary']) || !empty($variables['description']);

Can be $variables['caption_needed'] = TRUE; now. Then we preserve variable type and have less complexity.

I have addressed comment #20.

@ravi.shankar there's also some other unexpected change in #21 some path alias stuff.

Here we go, interdiff is against #7

#24 correctly addresses #18. Back to RTBC.

Thanks,
-Derek

Committed and pushed 5bd974ae17 to 9.1.x and 16ddcd41a6 to 9.0.x and 582584e499 to 8.9.x. Thanks!