See https://www.drupal.org/pift-ci-job/1699150

CommentFileSizeAuthor
#23 3145075-21.patch712 bytesjoseph.olstad
#21 3145075-21.patch712 bytesjoseph.olstad
#19 3145075-19.patch2.14 KBjibran
#17 3145075-17.patch706 bytesjibran
#14 3145075-14.patch17.66 KBjibran
#13 3145075-13.patch749 bytesjibran
#13 interdiff-89c4e1.txt749 bytesjibran
#11 3145075-11.patch17.6 KBjibran
#9 3145075-9.patch8.73 KBjibran
#9 interdiff-7bc344.txt1.9 KBjibran
#7 3145075-7.patch7.56 KBjibran

Comments

jibran created an issue. See original summary.

  • jibran committed 692bb6b on 3145075-drupalci-fix 
    Issue #3145075 by jibran: Fix DrupalCI fails

  • jibran committed 20000e2 on 1.0.x 
    Issue #3145075 by jibran: Fix DrupalCI fails

  • jibran committed 5a4c04a on 1.0.x 
    Issue #3145075 by jibran: Fix DrupalCI fails

  • jibran committed 2e2e31f on 1.0.x 
    Issue #3145075 by jibran: Fix DrupalCI fails

  • jibran committed b5667f0 on 1.0.x 
    Issue #3145075 by jibran: Fix DrupalCI fails
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 3145075-7.patch7.56 KB

Let's try patch from #2350939-96: Implement a generic revision UI.

Status: Needs review » Needs work

The last submitted patch, 7: 3145075-7.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-7bc344.txt1.9 KB
new 3145075-9.patch8.73 KB

  • jibran committed 9b7926a on 1.0.x 
    Issue #3145075 by jibran: Fix DrupalCI fails
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 3145075-11.patch17.6 KB

Updates for #2350939-127: Implement a generic revision UI.

Status: Needs review » Needs work

The last submitted patch, 11: 3145075-11.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-89c4e1.txt749 bytes
new 3145075-13.patch749 bytes

There is a change in ci setup to apply the patch.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 3145075-14.patch17.66 KB

With full patch this time.

Status: Needs review » Needs work

The last submitted patch, 14: 3145075-14.patch, failed testing. View results

  • jibran committed 8751ff7 on 1.0.x 
    Issue #3145075 by jibran: Fix DrupalCI fails
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 3145075-17.patch706 bytes

Status: Needs review » Needs work

The last submitted patch, 17: 3145075-17.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 3145075-19.patch2.14 KB

  • jibran committed ea4db70 on 1.0.x 
    Issue #3145075 by jibran: Updated the core patch version and fixed...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 3145075-21.patch712 bytes

New patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
Related issues: +#3336449: Fix webform_revision_ui HEAD tests

core patch needed a reroll, updating drupalci.yml

Please add a test for PHP 7.4 with D9.5.x
please add a test for PHP 8.0 with D9.5.x
please add a test for PHP 8.1 with D9.5.x

D10 will not apply the drupalci.yml patch as it's already included.

see D9.4.x/D9.5.x patch
#2350939-312: Implement a generic revision UI

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 3145075-21.patch712 bytes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

To me, its not obvious what the problem is. Any ideas?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Fix DrupalCI fails » Fix HEAD tests for config_revision for D9.5
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

#2350939: Implement a generic revision UI is committed now. Can we add the Drupal core constraint to the info file and remove the patch for testing?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

maybe set this to test only >= D10.1.x since D10.1.x has the required patch included in the latest release.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Fixed

Marking this as fixed, now we're into Drupal 11

#3451887: Automated Drupal 11 compatibility fixes for config_revision

I added a gitlab-ci file to the merge request in 3451887

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.