Comments

VladSavitsky created an issue. See original summary.

vladsavitsky’s picture

Status: Active » Needs review
StatusFileSize
new3.58 KB

Added patch which:

  • Adds checkbox to settings page.
  • Implements change of endpoint for UTMP requests.
vladsavitsky’s picture

Fixed paths in patch to pass tests.

vladsavitsky’s picture

:( Fixed php arrays to pass tests. Hope this helps.

vladsavitsky’s picture

Next attempt to pass testing.

vladsavitsky’s picture

Assigned: Unassigned » vladsavitsky
StatusFileSize
new3.22 KB

Fixed typo! :(

vladsavitsky’s picture

vladsavitsky’s picture

StatusFileSize
new3.28 KB

Fixed path to files which was broken by automatic replacement.

vladsavitsky’s picture

StatusFileSize
new2.51 KB

Recreated patch against 7.x-1.x-dev version of 'ga_push' module.

vladsavitsky’s picture

I did it! I'm the best!

vladsavitsky’s picture

Minor change. Added comment why some code was removed.

vladsavitsky’s picture

vladsavitsky’s picture

Fixed endpoint for standard ecommerce hits.

vladsavitsky’s picture

StatusFileSize
new3.08 KB
gedur’s picture

Nice contribution! Could you please provide the Drupal 8/9 patch? Drupal7 development is frozen, but we can add new features if they exists in the Drupal8 version.
Thanks in advance

vladsavitsky’s picture

StatusFileSize
new2.99 KB

I can't now port to D8/9. Updated patch to pass tests.

vladsavitsky’s picture

jordanmagnuson’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

Nice patch. Marking RTBC.

eduardo morales alberti’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Committed, pending to be ported to Drupal 8, thank you @VladSavitsky.

eduardo morales alberti’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.