This nice module needs Drupal 9 compatibility. According to Acquia deprecation tool there is one issue with the current module code:

https://dev.acquia.com/drupal9/deprecation_status/errors?name=%2Aapi_pro...

Class [redacted] implements deprecated interface Drupal​\​Component​\​Plugin​\​ConfigurablePluginInterface: Drupal​\​Component​\​Plugin​\​ConfigurablePluginInterface is deprecated in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement ConfigurableInterface and/or DependentPluginInterface directly as needed. If you implement ConfigurableInterface you may choose to implement ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility, however this must be removed prior to Drupal 9.

CommentFileSizeAuthor
#7 Drupal-9-readiness-3138316-7.patch1.28 KBramya balasubramanian
#2 Drupal-9-readiness-3138316-2.patch927 bytessahana _n

Comments

a.dmitriiev created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review
StatusFileSize
new Drupal-9-readiness-3138316-2.patch927 bytes

Please review the patch.
Thank you.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

Please add core_version_requirement key to module's .info.yml. Keep the "core: 8.x" line, as this module will still be compatible with Drupal 8.7 and above.

ramya balasubramanian’s picture

ramya balasubramanian commented
Assigned: Unassigned » ramya balasubramanian
jcnventura’s picture

jcnventura
Primary language English
commented

And also add DependentPluginInterface, as the module implements the calculateDependencies() method.

ramya balasubramanian’s picture

ramya balasubramanian commented

Hi @jcnventura,
Sure. I will add DependentPluginInterface along with other changes also.

ramya balasubramanian’s picture

ramya balasubramanian commented
Status: Needs work » Needs review
StatusFileSize
new Drupal-9-readiness-3138316-7.patch1.28 KB

Hi @jcnventura,

Please review this patch and let me know if there are any issues.

ramya balasubramanian’s picture

ramya balasubramanian commented
Assigned: ramya balasubramanian » Unassigned
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Reviewed & tested by the community
jcnventura’s picture

jcnventura
Primary language English
commented
Issue tags: +Drupal 9 porting weekend
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -ContributionWeekend2020
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone for making this happen! You are the best.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.