Call to deprecated method strtolower()

CommentFileSizeAuthor
#9 interdiff_4-9.txt2.25 KBmatroskeen
#9 3138033-9.patch3.93 KBmatroskeen
#4 interdiff_2-4.txt1.17 KBsuresh prabhu parkala
#4 3138033-4.patch1.68 KBsuresh prabhu parkala
#3 3138033-2.patch1.42 KBsoldrupal
#2 3138033.patch1.41 KBsoldrupal

Comments

soldrupal created an issue. See original summary.

soldrupal’s picture

soldrupal commented
StatusFileSize
new 3138033.patch1.41 KB
soldrupal’s picture

soldrupal commented
StatusFileSize
new 3138033-2.patch1.42 KB
suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3138033-4.patch1.68 KB
new interdiff_2-4.txt1.17 KB

Please review!

The last submitted patch, 3: 3138033-2.patch, failed testing. View results

soldrupal’s picture

soldrupal commented
soldrupal’s picture

soldrupal commented
Category: Bug report » Task
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Assigned: Unassigned » matroskeen
Status: Needs review » Needs work

The last patch looks good, however, tests are failing on D9 version for multiple reasons:
- missing core_version_requirement in test module;
- missing $defaultTheme property;
- failed asserts;

I'll try to take care of it.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs work » Needs review
Issue tags: +Drupal 9 porting weekend
StatusFileSize
new 3138033-9.patch3.93 KB
new interdiff_4-9.txt2.25 KB

Here is the new patch, where addressed the following issues:
1) Missing core_version_requirement property in reroute_email_test test module;
2) Missing $defaultTheme property in Functional tests (see: https://www.drupal.org/node/3083055);
3) Failed asserts:

Found the correct "Originally to" line in the body.
Failed asserting that 1 is true.

Drupal\Tests\reroute_email\Functional\TestEmailFormTest::testFormTestEmail
Found the correct "cc" line in the body.
Failed asserting that 1 is true.

Tests were passed running locally on D9 version. Interdiff attached.

It seems it's not possible to run tests with Drupal 9 version without core_version_requirement committed (because of failed composer require).
We can commit core_version_requirement changes first and then trigger test bot to make sure it's fine.
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Assigned: matroskeen » Unassigned

  • bohart committed 7ddab75 on 8.x-1.x authored by Matroskeen 
    Issue #3138033 by Matroskeen, bohart, soldrupal, Suresh Prabhu Parkala:...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs review » Fixed

Patch committed along with new releases created. Thanks, everyone!

All further works will be handled at #3042834: Drupal 10 Deprecated Code Report. This one marked as Fixed.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Why not make 2.0.0 also compatible with 8.8+?

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

re #13: good question. Is there a hard blocker from making it support 8.8+?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.