Drupal 9 readiness [#3136349]

Make this project compatible for drupal 9.
suggestions:

use drupal-check, rector , upgrade_status module to check the changes needed to be done
Add version key for drupal 9 in info.yml file.

Comment	File	Size	Author
#5	Screen Shot 2020-05-22 at 10.51.40 AM.png	12.41 KB	ramya balasubramanian
#3	drupal9-readiness-3136349-3.patch	892 bytes	pradeepjha

Issue fork nice_imagefield_widget-3136349

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3136349-drupal-9-readiness changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

13 May 2020 at 21:59

sarvjeetsingh created an issue. See original summary.

Comment #2

pradeepjha commented 22 May 2020 at 04:54

Assigned:

Unassigned

» pradeepjha

Comment #3

pradeepjha commented 22 May 2020 at 05:09

Assigned:	pradeepjha	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	drupal9-readiness-3136349-3.patch	892 bytes

Comment #4

pradeepjha commented 22 May 2020 at 05:17

Issue tags:

+Drupal 9 porting weekend, +DIACWMay2020

Comment #5

ramya balasubramanian commented 22 May 2020 at 05:26

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	Screen Shot 2020-05-22 at 10.51.40 AM.png	12.41 KB

I have checked this and this patch looks good to me!! I have attached screenshots also. Moving this to RTBC

Comment #6

vaibhavjain

he/him

Hindi

Delhi

commented 23 May 2020 at 02:36

Status:

Reviewed & tested by the community

» Needs work

@pradeepjha @Ramya Balasubramanian This an API change, mentioned here https://www.drupal.org/node/3084730 Can you please make sure that there is no Code change involved ? Also, is the module functioning well tested on D9 branch ?

Comment #7

pradeepjha commented 23 May 2020 at 05:57

Status:

Needs work

» Needs review

Thanks @vaibhavjain. Your point is valid.
We have one similar ticket https://www.drupal.org/project/draggable_dashboard/issues/3128932, which is now in fixed state. There also the "core/jquery.ui.sortable" asset library is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. We have applied similar patch to fix it. Still someone can apply patch and test it the functionality. I think better we can move it to `in review` state.

Comment #8

vaibhavjain

he/him

Hindi

Delhi

commented 24 May 2020 at 11:54

Sure, @pradeepjha. We have done some similar implementation here (https://www.drupal.org/project/autocomplete_deluxe/issues/3122933), where jQuery sortable was replaced with core/sortable. If you plan to debug this further, you may want to refer to the above issue.