Looks like this module has no deprecated code issues. So add core_version_requirement: ^8 || ^9 to .info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#2 3136178-2.patch339 byteskarishmaamin
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

karishmaamin created an issue. See original summary.

karishmaamin’s picture

Status: Active » Needs review
StatusFileSize
new339 bytes
kristen pol’s picture

Issue tags: +Drupal 9 compatibility
Webbeh’s picture

Status: Needs review » Reviewed & tested by the community

Self-explanatory change and looks good. RTBC.

casivaagustin’s picture

The patch looks good and works on my end.

gerzenstl’s picture

The patch works fine on Drupal 9.

Is there anything else we can help with to release soon this fix?

matt.hood made their first commit to this issue’s fork.

darkodev’s picture

Patch works.

Another respectful request for maintainer to push this so that we can install the module with composer.

alexmoreno’s picture

same, patch works, but it's making it quite a nightmare to update to D9 with composer with no actual version published :-(

alexmoreno’s picture

it's lacking a composer.json as well

alexmoreno’s picture

I have created this MR: https://git.drupalcode.org/project/embed_view_block/-/merge_requests/3/d...

and this branch: https://git.drupalcode.org/issue/embed_view_block-3136178/-/tree/dev-313...

which contains the changes from 3136178-2.patch

You just need to tell composer where to find them:

    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": ["drupal/embed_view_block"]

        },
        {
            "type": "git",
            "url": "git@git.drupal.org:issue/embed_view_block-3136178.git"
        }
    ],

then add this package:

        "drupal/embed_view_block": "dev-3136178-drupal9"

which points to the branch I was mentioning onthe beginning.

From there, just run a composer update and all should install just fine.

For a much longer explanation see https://www.mediacurrent.com/blog/how-fix-catch-22-problem-drupal-9-fixe...

I hope it helps.

jackfoust’s picture

If you're trying Alex's solution in #14 and you run into permission errors, make sure you've added your SSH key to your drupal.org profile.

bigjim’s picture

Another vote for committing patch, the solution in #14 doesn't work if you are compiling site using composer on Pantheon as Pantheon runs into the permission issues sited in #15, as Pantheon does not have a public key registered with GitLab :(.

alexmoreno’s picture

yes, I'm suddenly having issues as well. Can somone please commit this ?

alexmoreno’s picture

just a note on this, my issue was related to the ssh key not being propagated correctly in the docker container I was using.

I simply run:

```ddev auth ssh```

and everything was fine afterwards. You may be hitting a similar problem with Vagrant or docker.

$ ddev composer require drupal/lazyloader
Using version ^1.0@alpha for drupal/lazyloader
./composer.json has been updated
Running composer update drupal/lazyloader
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information

Installation failed, reverting ./composer.json and ./composer.lock to their original content.


  [RuntimeException]
  Failed to execute git clone --mirror -- 'git@git.drupal.org:issue/embed_view_block-3136178.git' '/mnt/ddev-global-cache/composer/vcs/git-git.drupal.org-issue-embed-view-block-3136178.git/'

  Cloning into bare repository '/mnt/ddev-global-cache/composer/vcs/git-git.drupal.org-issue-embed-view-block-3136178.git'...
  git@git.drupal.org: Permission denied (publickey).
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.

Fix:


$ ddev auth ssh
Identity added: id_rsa (xxxxxx)
 ddev composer require drupal/lazyloader
Using version ^1.0@alpha for drupal/lazyloader
./composer.json has been updated
Running composer update drupal/lazyloader
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies
Lock file operations: 2 installs, 0 updates, 0 removals
  - Locking dawehner/lazysizes (dev-master 3252c36)
  - Locking drupal/lazyloader (1.0.0-alpha4)
Writing lock file

Webbeh’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your patience as I was added as a co-maintainer. Fixed and credited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.