While the main drd module's info.yml file has been updated to include the core_version_requirement for D9 compatibility, the various submodules included with it have not.

This may be intentional -- perhaps they still need to be updated. I'm not sure how to tell. But in case it was merely an oversight, this patch adds the key to each of the six info.yml files so that the module doesn't (hopefully) cause the module administration page to whitescreen.

CommentFileSizeAuthor
add_core_requirements.patch2.38 KBwrd

Comments

wrd created an issue. See original summary.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Active » Needs review

This is marked "Active" but it looks like it should be "Needs review" because of the patch.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 9 compatibility
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Drupal 9 porting weekend

Please commit this to the 3.x branch, since that branch is now marked also compatible with Drupal 9. I see that a similar commit was already added to the 4.0.x branch with https://git.drupalcode.org/project/drd/commit/4ee19e2

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

@jcnventura the changed release tags sneaked into the 3.x branch by mistake. The plan has been - and still is - that 8.x-3.23 remains as is (ideally without the D9 compatibility tag) - and that 4.0.x is the release moving forward which requires at least 8.8.3 and is going to be D9 compatible as well. Apart from that, 4.0.0 will be the same as 3.23 and everything else in the issue queue will be going into that release.

Not sure if and how I can undo the compatibility tag in 3.23, but we may just have to live with it as is. OK for you?

jcnventura’s picture

jcnventura
Primary language English
commented

@jurgenhaas In that case, better release a 8.x-3.24 release that removes the core_version_requirement from the module info.yml files from that branch.

And update the project page to state that only 4.x versions are compatible with D9.

  • jurgenhaas committed 6c2a1a0 on 8.x-3.x 
    Issue #3134576 by wrd, jcnventura: Included modules need...
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Assigned: Unassigned » jurgenhaas
Status: Reviewed & tested by the community » Fixed

Done that, thanks for your feedback.

  • jurgenhaas committed 6c2a1a0 on 4.0.x 
    Issue #3134576 by wrd, jcnventura: Included modules need...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.