Besides #3133098: gin--classic-toolbar class given although toolbar not present I see two more styling issues when using the classic toolbar. I am using alpha11 to avoid seeing potential issues from the fix in #3125121: CSS/JS files missing for anonymous users (although the same issues also happen with latest dev).
See the gap between the header and buttons.
I'm not seeing this when the gin--classic-toolbar class is removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | gin-sticky-header-quirk-2.gif | 1.97 MB | anruether |
| #5 | gin-sticky-header-quirk-1.gif | 2.69 MB | anruether |
| gin-2-sticky-header-issue.gif | 2.77 MB | anruether | |
| gin-1-header-style-gap.png | 315.92 KB | anruether |
Comments
Comment #2
anruetherComment #4
saschaeggiPlease check the latest dev :)
Comment #5
anruetherThanks for the quick response (once again :)
1. is gone and for 2. I see some quirks when the header sticks for the first time after a page reload (Alt-F5) or cache rebuild.
After Alt-F5
After drush cr
Comment #6
saschaeggi@anruether the question is if this is related to Gin. Can you maybe try if you have the same behaviour in Claro as well?
Comment #7
saschaeggiUnrelated but is the "Admin Toolbar quick search" part of the Admin Toolbar module?
Comment #8
anruetherRight that happens in claro (and in seven ;) as well.
Yes, it was merged into admin_toolbar as a submodule, see the old project page: https://www.drupal.org/project/admin_toolbar_search
Comment #9
saschaeggiWas that the one you talked about? If yes, feel free to create a ticket and add it to the Roadmap :)
Comment #10
anruetherYes thanks! Actually atm I prefer coffee over the search toolbar. But I have something else as a feature request ;)
Comment #11
saschaeggiRolled out with 8.x-3.x-alpha12