Just a minor. Composer validate throws a warning.

martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/modules/contrib/devel (8.x-2.x *=) $ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead
CommentFileSizeAuthor
#9 Screen Shot 2020-04-30 at 11.43.28.png103.63 KBjonathan1055
#8 TableField Drupal org.jpg6.79 KBlolandese
#5 3131940-5.deprecated_license_identifier.3x.patch728 bytesjonathan1055
#4 devel-deprecated_license_identifier-3131940-4.patch1.09 KBlolandese
#2 devel-deprecated_license_identifier-3131940-2.patch390 byteslolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new devel-deprecated_license_identifier-3131940-2.patch390 bytes

After applying the attached patch it is solved:

martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/modules/contrib/devel (8.x-2.x=) $ composer validate
./composer.json is valid
lolandese’s picture

lolandese commented
Status: Needs review » Needs work

That's not the only occurrence. There are other composer.json files in the project.

lolandese’s picture

lolandese commented
Status: Needs work » Needs review
StatusFileSize
new devel-deprecated_license_identifier-3131940-4.patch1.09 KB

The attached patch fixes all three occurrences.

There is a fourth file, kint/kint/composer.json, but that one validates already.

martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/modules/contrib/devel (8.x-2.x *=) $ cd kint/kint/
martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/modules/contrib/devel/kint/kint (8.x-2.x *=) $ composer validate
./composer.json is valid
jonathan1055’s picture

jonathan1055 commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
StatusFileSize
new 3131940-5.deprecated_license_identifier.3x.patch728 bytes

Hi @lolandese,

Thanks for raising this, and for providing the patch. In 8.x-3.x the main composer.json has been corrected (recently) but the other two have not been. Here's the patch for 8.x-3.x as fixes like this must be done in the highest version branch first.

lolandese’s picture

lolandese commented

Hi Jonathan,

That makes sense. I suggest you change the default branch that is indicated when you go to https://www.drupal.org/project/devel/git-instructions in your project settings.

In any case, I guess you need to backport the patch anyway. So that is then already provided to be committed to the 8.x-2.x branch.

jonathan1055’s picture

jonathan1055 commented

Yes, that's fine, thanks.
The reason why 3.x is not the default branch is that it does not yet have a full release, it is only at beta. See #3112287: Plan for Devel 8.x-3.0 / 4.0.0 release

lolandese’s picture

lolandese commented
StatusFileSize
new TableField Drupal org.jpg6.79 KB

Hi. Apologies. What I meant was the version to work from.

Setting on tab Version control

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new Screen Shot 2020-04-30 at 11.43.28.png103.63 KB

Yes, that's what I meant too. We could but should not really change the default branch to 3.x until we have a full 3.0 release.

  • jonathan1055 committed a80d517 on 8.x-3.x 
    Issue #3131940 by lolandese, jonathan1055: License "GPL-2.0+" is a...

  • jonathan1055 committed 89586f7 on 8.x-3.x 
    Issue #3131940 by jonathan1055: Remove vendor alias committed by mistake
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Thanks lolandese, committed to 3.x and 2.x and fixed.

We now get

composer validate
./composer.json is valid

for all the composer.json files.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.